chore: assetsディレクトリをGit管理下から削除
#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Chore to remove unused /assets/ directory now replaced by external typst-dev-assets and add image file output support in TestResolver.
- Deleted legacy example asset files under
assets/files/ - Prepared for moving website asset output path in a follow-up PR
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assets/files/*.bib | Removed unused bibliography example files |
| assets/files/*.json | Removed unused JSON example files |
| assets/files/*.toml | Removed unused TOML example files |
| assets/files/*.yaml | Removed unused YAML example files |
| assets/files/*.xml | Removed unused XML example files |
| assets/files/*.html/.csv/.txt | Removed other unused example data files |
| assets/files/SExpressions.sublime-syntax | Removed unused syntax definition file |
3w36zj6
force-pushed
the
feature/remove-assets-directory
branch
from
900ffbe to
ba831a9
Compare
kimushun1101
approved these changes
Jun 12, 2025
ultimatile
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #129
背景
Exampleコードの実行結果の画像の生成の際に必要なアセットは既にtypst-dev-assetsから取得されるようになっていますが、不要な
/assets/ディレクトリが残ったままであったため削除しました。また、Markdownの文章中にある画像ファイルを扱うために
TestResolverに画像のファイル出力を実装しました。備考
Webサイトで必要なアセットの出力先は
/assets/docs/である必要がなくなったので、別のPRで出力先を/website/以下に変更できます。