test(animes, characters): create new folder structure and update integration tests

Author: tyronejosee

apps/animes/tests/integration/test_endpoints.py

@@ -25,23 +25,26 @@
 
 @pytest.mark.django_db
 def test_list_animes(anonymous_user, anime):
-    response = anonymous_user.get("/api/v1/animes/")
+    endpoint = "/api/v1/animes/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) > 0
 
 
 @pytest.mark.django_db
 def test_list_animes_errors(anonymous_user):
-    response = anonymous_user.get("/api/v1/animes/")
+    endpoint = "/api/v1/animes/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     # TODO: Update status code to 404
 
 
 @pytest.mark.django_db
 def test_retrieve_anime(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/")
+    endpoint = f"/api/v1/animes/{anime.id}/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert str(response.data["id"]) == str(anime.id)
@@ -51,7 +54,8 @@ def test_retrieve_anime(anonymous_user, anime):
 @pytest.mark.django_db
 def test_retrieve_anime_errors(anonymous_user):
     anime_id = "989423d1-d6c0-431a-8f62-d805b8a5f321"
-    response = anonymous_user.get(f"/api/v1/animes/{anime_id}/")
+    endpoint = f"/api/v1/animes/{anime_id}/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
 
@@ -60,6 +64,7 @@ def test_retrieve_anime_errors(anonymous_user):
 def test_create_anime(contributor_user, genre, theme):
     producer = ProducerFactory(type=TypeChoices.STUDIO)
     image = generate_test_image(size=(600, 600))
+    endpoint = "/api/v1/animes/"
     data = {
         "name": "New Anime",
         "name_jpn": "New Anime",
@@ -72,7 +77,7 @@ def test_create_anime(contributor_user, genre, theme):
         "themes": [str(theme.id)],
         "duration": timedelta(hours=1, minutes=45, seconds=30),
     }
-    response = contributor_user.post("/api/v1/animes/", data, format="multipart")
+    response = contributor_user.post(endpoint, data, format="multipart")
     assert response.status_code == status.HTTP_201_CREATED
     assert response.reason_phrase == "Created"
     assert Anime.objects.filter(name="New Anime").exists()
@@ -81,12 +86,13 @@ def test_create_anime(contributor_user, genre, theme):
 
 @pytest.mark.django_db
 def test_create_anime_errors(member_user):
+    endpoint = "/api/v1/animes/"
     data = {}
-    member_response = member_user.post("/api/v1/animes/", data, format="json")
+    member_response = member_user.post(endpoint, data, format="json")
     assert member_response.status_code == status.HTTP_403_FORBIDDEN
     assert member_response.reason_phrase == "Forbidden"
     member_user.logout()
-    anonymus_response = member_user.post("/api/v1/animes/", data, format="json")
+    anonymus_response = member_user.post(endpoint, data, format="json")
     assert anonymus_response.status_code == status.HTTP_401_UNAUTHORIZED
     assert anonymus_response.reason_phrase == "Unauthorized"
 
@@ -95,6 +101,7 @@ def test_create_anime_errors(member_user):
 def test_update_anime(contributor_user, anime, genre, theme):
     producer = ProducerFactory(type=TypeChoices.STUDIO)
     image = generate_test_image(size=(600, 600))
+    endpoint = f"/api/v1/animes/{anime.id}/"
     data = {
         "name": "Updated Anime",
         "name_jpn": "Updated Anime",
@@ -107,9 +114,7 @@ def test_update_anime(contributor_user, anime, genre, theme):
         "themes": [str(theme.id)],
         "duration": timedelta(hours=1, minutes=45, seconds=30),
     }
-    response = contributor_user.put(
-        f"/api/v1/animes/{anime.id}/", data, format="multipart"
-    )
+    response = contributor_user.put(endpoint, data, format="multipart")
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     anime.refresh_from_db()
@@ -118,12 +123,9 @@ def test_update_anime(contributor_user, anime, genre, theme):
 
 @pytest.mark.django_db
 def test_partial_update_anime(contributor_user, anime):
+    endpoint = f"/api/v1/animes/{anime.id}/"
     data = {"name": "Partially Updated Anime"}
-    response = contributor_user.patch(
-        f"/api/v1/animes/{anime.id}/",
-        data,
-        format="json",
-    )
+    response = contributor_user.patch(endpoint, data, format="json")
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     anime.refresh_from_db()
@@ -133,7 +135,8 @@ def test_partial_update_anime(contributor_user, anime):
 @pytest.mark.django_db
 def test_delete_anime(contributor_user, anime):
     assert anime.is_available
-    response = contributor_user.delete(f"/api/v1/animes/{anime.id}/")
+    endpoint = f"/api/v1/animes/{anime.id}/"
+    response = contributor_user.delete(endpoint)
     anime.refresh_from_db()
     assert response.status_code == status.HTTP_204_NO_CONTENT
     assert response.reason_phrase == "No Content"
@@ -144,15 +147,17 @@ def test_delete_anime(contributor_user, anime):
 @pytest.mark.django_db
 def test_list_characters_by_anime(anonymous_user, anime, character):
     CharacterAnimeFactory(character_id=character, anime_id=anime)
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/characters/")
+    endpoint = f"/api/v1/animes/{anime.id}/characters/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) == 1
 
 
 @pytest.mark.django_db
 def test_list_characters_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/characters/")
+    endpoint = f"/api/v1/animes/{anime.id}/characters/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No characters found for this anime."
@@ -164,7 +169,8 @@ def test_list_staff_by_anime(anonymous_user, anime):
     staff_two = PersonFactory()
     StaffAnimeFactory(person_id=staff_one, anime_id=anime)
     StaffAnimeFactory(person_id=staff_two, anime_id=anime)
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/staff/")
+    endpoint = f"/api/v1/animes/{anime.id}/staff/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     staff_ids = StaffAnime.objects.filter(anime_id=anime.id).values_list(
@@ -177,15 +183,17 @@ def test_list_staff_by_anime(anonymous_user, anime):
 
 @pytest.mark.django_db
 def test_list_staff_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/staff/")
+    endpoint = f"/api/v1/animes/{anime.id}/staff/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No staff found for this anime."
 
 
 @pytest.mark.django_db
 def test_retrieve_stats_by_anime(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/stats/")
+    endpoint = f"/api/v1/animes/{anime.id}/stats/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert "id" in response.data
@@ -200,7 +208,8 @@ def test_retrieve_stats_by_anime(anonymous_user, anime):
 @pytest.mark.django_db
 def test_retrieve_stats_by_anime_errors(anonymous_user):
     anime_id = "88bf5d4f-115b-4dea-a7c5-4fc45b794c9a"
-    response = anonymous_user.get(f"/api/v1/animes/{anime_id}/stats/")
+    endpoint = f"/api/v1/animes/{anime_id}/stats/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "Not found."
@@ -212,7 +221,8 @@ def test_list_reviews_by_anime(anonymous_user, anime):
         content_type=ContentType.objects.get_for_model(Anime),
         object_id=anime.id,
     )
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/reviews/")
+    endpoint = f"/api/v1/animes/{anime.id}/reviews/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) > 0
@@ -221,14 +231,13 @@ def test_list_reviews_by_anime(anonymous_user, anime):
 
 @pytest.mark.django_db
 def test_create_review_by_anime(member_user, anime, review):
+    endpoint = f"/api/v1/animes/{anime.id}/reviews/create/"
     data = {
         "comment": "Review created",
         "is_spoiler": review.is_spoiler,
         "rating": review.rating,
     }
-    response = member_user.post(
-        f"/api/v1/animes/{anime.id}/reviews/create/", data, format="json"
-    )
+    response = member_user.post(endpoint, data, format="json")
     assert response.status_code == status.HTTP_201_CREATED
     assert response.reason_phrase == "Created"
     assert Review.objects.filter(comment="Review created").exists()
@@ -245,14 +254,13 @@ def test_update_review_by_anime(anime):
         content_type=ContentType.objects.get_for_model(Anime),
         object_id=anime.id,
     )
+    endpoint = f"/api/v1/animes/{anime.id}/reviews/{review.id}/"
     data = {
         "comment": "Review updated",
         "is_spoiler": review.is_spoiler,
         "rating": review.rating,
     }
-    response = api_client.patch(
-        f"/api/v1/animes/{anime.id}/reviews/{review.id}/", data, format="json"
-    )
+    response = api_client.patch(endpoint, data, format="json")
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     anime.refresh_from_db()
@@ -263,15 +271,17 @@ def test_update_review_by_anime(anime):
 def test_list_recommendations_by_anime(anonymous_user, theme, genre):
     anime = AnimeFactory(genres=[genre], themes=[theme])
     AnimeFactory.create_batch(3, genres=[genre], themes=[theme])
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/recommendations/")
+    endpoint = f"/api/v1/animes/{anime.id}/recommendations/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) == 3
 
 
 @pytest.mark.django_db
 def test_list_recommendations_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/recommendations/")
+    endpoint = f"/api/v1/animes/{anime.id}/recommendations/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No recommendations found for this anime."
@@ -280,15 +290,17 @@ def test_list_recommendations_by_anime_errors(anonymous_user, anime):
 @pytest.mark.django_db
 def test_list_news_by_anime(anonymous_user, anime):
     NewsFactory.create_batch(3, anime_relations=[anime])
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/news/")
+    endpoint = f"/api/v1/animes/{anime.id}/news/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) == 3
 
 
 @pytest.mark.django_db
 def test_list_news_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/news/")
+    endpoint = f"/api/v1/animes/{anime.id}/news/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No news found for this anime."
@@ -301,15 +313,17 @@ def test_list_videos_by_anime(anonymous_user, anime):
         content_type=ContentType.objects.get_for_model(Anime),
         object_id=anime.id,
     )
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/videos/")
+    endpoint = f"/api/v1/animes/{anime.id}/videos/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) == 3
 
 
 @pytest.mark.django_db
 def test_list_videos_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/videos/")
+    endpoint = f"/api/v1/animes/{anime.id}/videos/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No videos found for this anime."
@@ -322,15 +336,17 @@ def test_list_pictures_by_anime(anonymous_user, anime):
         content_type=ContentType.objects.get_for_model(Anime),
         object_id=anime.id,
     )
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/pictures/")
+    endpoint = f"/api/v1/animes/{anime.id}/pictures/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_200_OK
     assert response.reason_phrase == "OK"
     assert len(response.data) == 3
 
 
 @pytest.mark.django_db
 def test_list_pictures_by_anime_errors(anonymous_user, anime):
-    response = anonymous_user.get(f"/api/v1/animes/{anime.id}/pictures/")
+    endpoint = f"/api/v1/animes/{anime.id}/pictures/"
+    response = anonymous_user.get(endpoint)
     assert response.status_code == status.HTTP_404_NOT_FOUND
     assert response.reason_phrase == "Not Found"
     assert response.data["detail"] == "No pictures found for this anime."

apps/animes/tests/unit/test_models.py

@@ -4,7 +4,6 @@
 from django.db import IntegrityError
 from django.core.exceptions import ValidationError
 
-# from apps.utils.functions import generate_test_image
 from ...choices import DayChoices
 from ..factories import BroadcastFactory, AnimeFactory
 
@@ -52,6 +51,3 @@ def test_field_string_max_length(self):
         anime = AnimeFactory.create(name="a" * 256)  # Max 255
         with pytest.raises(ValidationError):
             anime.full_clean()
-
-    # def test_field_invalid_dimensions_image(self, anime):
-    #     pass

apps/animes/tests/unit/test_serializers.py

@@ -23,7 +23,6 @@ def test_broadcast_minimal_serializer(self, broadcast):
             "time": broadcast.time.isoformat(),
             "timezone": broadcast.timezone,
         }
-
         assert serializer.data == expected_data
 
 
@@ -99,7 +98,6 @@ def test_anime_read_serializer(self, anime):
             "members": anime.members,
             "favorites": anime.favorites,
         }
-
         assert serializer.data == expected_data
 
     def test_anime_write_serializer_valid_data(self, anime):
@@ -131,7 +129,6 @@ def test_anime_write_serializer_valid_data(self, anime):
             "website": anime.website,
         }
         serializer = AnimeWriteSerializer(data=data)
-
         assert serializer.is_valid(), serializer.errors
         assert serializer.validated_data["name"] == "Chainsaw Man"
         assert serializer.validated_data["name_jpn"] == "チェンソーマン"
@@ -140,7 +137,6 @@ def test_anime_write_serializer_valid_data(self, anime):
     def test_anime_write_serializer_invalid_data(self):
         data = {}
         serializer = AnimeWriteSerializer(data=data)
-
         assert not serializer.is_valid()
         assert "name" in serializer.errors
         assert "name_jpn" in serializer.errors
@@ -169,7 +165,6 @@ def test_anime_minimal_serializer(self, anime):
             "members": anime.members,
             "favorites": anime.favorites,
         }
-
         assert serializer.data == expected_data
 
     # TODO: Add AnimeStatsReadSerializer test