fix(ai): sanitize response strings

Author: tyzbit

filter_ollama.go

@@ -16,7 +16,7 @@ import (
 var (
 	OllamaSystemPrompt = `You will carefully evaluate a message to
 determine if it matches specific criteria. Provide a very short explanation
-for your reasoning.
+for your reasoning. Return as JSON.
 `
 	OllamaTimeout             = 120
 	OllamaMaxPredictionTokens = 512
@@ -103,6 +103,8 @@ func OllamaFilter(m string) bool {
 		Options: map[string]interface{}{
 			// Hopefully minimizes the model timing out
 			"num_predict": OllamaMaxPredictionTokens,
+			// Make output deterministic
+			"temperature": 0,
 		},
 	}
 
@@ -120,6 +122,7 @@ func OllamaFilter(m string) bool {
 		start, end := matches[len(matches)-1][0], matches[len(matches)-1][1]
 		content := resp.Response[start:end]
 
+		content = SanitizeJSONString(content)
 		err = json.Unmarshal([]byte(content), &r)
 		if err != nil {
 			err = fmt.Errorf("%w, ollama full response: %s", err, resp.Response)

filter_openai.go

@@ -10,9 +10,8 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
-var OpenAISystemPrompt string = `You are an API that only responds in
-valid JSON objects. You will carefully evaluate a message to determine if it 
-matches specific criteria.
+var OpenAISystemPrompt string = `You will carefully evaluate a message to 
+determine if it matches specific criteria. Return as JSON.
 
 If the message matches the criteria, "decision" will ALWAYS be true: 
 {"decision": true, "reasoning": "REASON"}
@@ -45,6 +44,7 @@ func OpenAIFilter(m string) bool {
 	if config.OpenAIModel != "" {
 		openAIModel = config.OpenAIModel
 	}
+
 	log.Debugf("calling OpenAI model %s", openAIModel)
 	chatCompletion, err := client.Chat.Completions.New(context.TODO(),
 		openai.ChatCompletionNewParams{
@@ -54,6 +54,8 @@ func OpenAIFilter(m string) bool {
 				openai.UserMessage(m),
 			}),
 			Model: openai.F(openAIModel),
+			// Make it deterministic
+			Temperature: openai.Float(0),
 		})
 	if err != nil {
 		log.Errorf("error using OpenAI: %s", err)
@@ -74,6 +76,7 @@ func OpenAIFilter(m string) bool {
 	}
 	start, end := matches[len(matches)-1][0], matches[len(matches)-1][1]
 	content := chatCompletion.Choices[0].Message.Content[start:end]
+	content = SanitizeJSONString(content)
 	err = json.Unmarshal([]byte(content), &r)
 
 	if err != nil {

go.mod

@@ -14,13 +14,18 @@ require (
 
 require (
 	github.com/BurntSushi/toml v1.2.1 // indirect
+	github.com/bahlo/generic-list-go v0.2.0 // indirect
+	github.com/buger/jsonparser v1.1.1 // indirect
 	github.com/golobby/cast v1.3.3 // indirect
 	github.com/golobby/dotenv v1.3.2 // indirect
 	github.com/golobby/env/v2 v2.2.4 // indirect
+	github.com/invopop/jsonschema v0.13.0 // indirect
+	github.com/mailru/easyjson v0.7.7 // indirect
 	github.com/tidwall/gjson v1.14.4 // indirect
 	github.com/tidwall/match v1.1.1 // indirect
 	github.com/tidwall/pretty v1.2.1 // indirect
 	github.com/tidwall/sjson v1.2.5 // indirect
+	github.com/wk8/go-ordered-map/v2 v2.1.8 // indirect
 	golang.org/x/sys v0.30.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -1,5 +1,9 @@
 github.com/BurntSushi/toml v1.2.1 h1:9F2/+DoOYIOksmaJFPw1tGFy1eDnIJXg+UHjuD8lTak=
 github.com/BurntSushi/toml v1.2.1/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
+github.com/bahlo/generic-list-go v0.2.0 h1:5sz/EEAK+ls5wF+NeqDpk5+iNdMDXrh3z3nPnH1Wvgk=
+github.com/bahlo/generic-list-go v0.2.0/go.mod h1:2KvAjgMlE5NNynlg/5iLrrCCZ2+5xWbdbCW3pNTGyYg=
+github.com/buger/jsonparser v1.1.1 h1:2PnMjfWD7wBILjqQbt530v576A/cAbQvEW9gGIpYMUs=
+github.com/buger/jsonparser v1.1.1/go.mod h1:6RYKKt7H4d4+iWqouImQ9R2FZql3VbhNgx27UK13J/0=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
@@ -14,15 +18,20 @@ github.com/golobby/env/v2 v2.2.4 h1:sjdTe+bScPRWUIA1AQH95RHv52jM5Mns2XHwLyEbkzk=
 github.com/golobby/env/v2 v2.2.4/go.mod h1:HDJW+dHHwLxkb8FZMjBTBiZUFl1iAA4F9YX15kBC84c=
 github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
 github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
+github.com/invopop/jsonschema v0.13.0 h1:KvpoAJWEjR3uD9Kbm2HWJmqsEaHt8lBUpd0qHcIi21E=
+github.com/invopop/jsonschema v0.13.0/go.mod h1:ffZ5Km5SWWRAIN6wbDXItl95euhFz2uON45H2qjYt+0=
 github.com/jftuga/geodist v1.0.0 h1:PFPQlZtj10u8ETAYTyxE0DWMl1bwA+Xzrqb4+oLkkC0=
 github.com/jftuga/geodist v1.0.0/go.mod h1:BohEDxpZ8S5ADAxW/9EKPSKWOVl0+3wHENIT40m4UO4=
+github.com/josharian/intern v1.0.0/go.mod h1:5DoeVV0s6jJacbCEi61lwdGj/aVlrQvzHFFd8Hwg//Y=
 github.com/kr/pretty v0.2.1/go.mod h1:ipq/a2n7PKx3OHsz4KJII5eveXtPO4qwEXGdVfWzfnI=
 github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
 github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
 github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
 github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
 github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
+github.com/mailru/easyjson v0.7.7 h1:UGYAvKxe3sBsEDzO8ZeWOSlIQfWFlxbzLZe7hwFURr0=
+github.com/mailru/easyjson v0.7.7/go.mod h1:xzfreul335JAWq5oZzymOObrkdz5UnU4kGfJJLY9Nlc=
 github.com/newrelic/newrelic-telemetry-sdk-go v0.8.1 h1:6OX5VXMuj2salqNBc41eXKz6K+nV6OB/hhlGnAKCbwU=
 github.com/newrelic/newrelic-telemetry-sdk-go v0.8.1/go.mod h1:2kY6OeOxrJ+RIQlVjWDc/pZlT3MIf30prs6drzMfJ6E=
 github.com/ollama/ollama v0.6.1 h1:M+wxOCuC1hKhHd6a8zNuJl6jYiRPsi/JFd4QoU0P5BQ=
@@ -57,6 +66,8 @@ github.com/tidwall/sjson v1.2.5 h1:kLy8mja+1c9jlljvWTlSazM7cKDRfJuR/bOJhcY5NcY=
 github.com/tidwall/sjson v1.2.5/go.mod h1:Fvgq9kS/6ociJEDnK0Fk1cpYF4FIW6ZF7LAe+6jwd28=
 github.com/tidwall/words v0.0.0-20181116223016-6463671b7759 h1:y3CDYT8Qw7Gmll8W8OvgVdRX3Va70xJqSBaKaeILSAY=
 github.com/tidwall/words v0.0.0-20181116223016-6463671b7759/go.mod h1:calX3QB7ABamqPLok6zrdMw6kcIsxErDVuPEHCETil8=
+github.com/wk8/go-ordered-map/v2 v2.1.8 h1:5h/BUHu93oj4gIdvHHHGsScSTMijfx5PeYkE/fJgbpc=
+github.com/wk8/go-ordered-map/v2 v2.1.8/go.mod h1:5nJHM5DyteebpVlHnWMV0rPz6Zp7+xBAnxjb1X5vnTw=
 golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
 golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=

util.go

@@ -66,3 +66,14 @@ func AircraftOrTower(s string) (r string) {
 	}
 	return "Tower"
 }
+
+// Fixes AI output bullshit
+func SanitizeJSONString(s string) string {
+	replacer := strings.NewReplacer(
+		"“", "\"",
+		"”", "\"",
+		"‘", "'",
+		"’", "'",
+	)
+	return replacer.Replace(s)
+}