test(aws): add comprehensive tests and remove old logic

Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com>

Author: u-kai

provider/aws/aws.go

@@ -898,7 +898,7 @@ func (p *AWSProvider) adjustEndpointAndNewAaaaIfNeeded(ep *endpoint.Endpoint) *e
 			ep.DeleteProviderSpecificProperty(providerSpecificEvaluateTargetHealth)
 		}
 	default:
-		// TODO fix
+		// TODO: fix For records other than A, AAAA, and CNAME, if an alias record is set, the alias record processing is not performed. This will be fixed in another PR.
 		aliasString, _ := ep.GetProviderSpecificProperty(providerSpecificAlias)
 		switch aliasString {
 		case "true":
@@ -914,67 +914,6 @@ func (p *AWSProvider) adjustEndpointAndNewAaaaIfNeeded(ep *endpoint.Endpoint) *e
 	return additionalAAAA
 }
 
-func (p *AWSProvider) oldAdjustEndpointAndNewAaaaIfNeeded(ep *endpoint.Endpoint) *endpoint.Endpoint {
-	var result *endpoint.Endpoint
-
-	alias := false
-
-	if aliasString, ok := ep.GetProviderSpecificProperty(providerSpecificAlias); ok {
-		alias = aliasString == "true"
-		if alias {
-			if !slices.Contains([]string{endpoint.RecordTypeA, endpoint.RecordTypeAAAA, endpoint.RecordTypeCNAME}, ep.RecordType) {
-				ep.DeleteProviderSpecificProperty(providerSpecificAlias)
-			}
-		} else {
-			if ep.RecordType == endpoint.RecordTypeCNAME {
-				if aliasString != "false" {
-					ep.SetProviderSpecificProperty(providerSpecificAlias, "false")
-				}
-			} else {
-				ep.DeleteProviderSpecificProperty(providerSpecificAlias)
-			}
-		}
-	} else if ep.RecordType == endpoint.RecordTypeCNAME {
-		alias = useAlias(ep, p.preferCNAME)
-		log.Debugf("Modifying endpoint: %v, setting %s=%v", ep, providerSpecificAlias, alias)
-		ep.SetProviderSpecificProperty(providerSpecificAlias, strconv.FormatBool(alias))
-	}
-
-	if alias {
-		if ep.RecordTTL.IsConfigured() {
-			log.Debugf("Modifying endpoint: %v, setting ttl=%v", ep, defaultTTL)
-			ep.RecordTTL = defaultTTL
-		}
-		if prop, ok := ep.GetProviderSpecificProperty(providerSpecificEvaluateTargetHealth); ok {
-			if prop != "true" && prop != "false" {
-				ep.SetProviderSpecificProperty(providerSpecificEvaluateTargetHealth, "false")
-			}
-		} else {
-			ep.SetProviderSpecificProperty(providerSpecificEvaluateTargetHealth, strconv.FormatBool(p.evaluateTargetHealth))
-		}
-
-		if ep.RecordType == endpoint.RecordTypeCNAME {
-			// This needs to match two records from Route53, one alias for 'A' (IPv4)
-			// and one alias for 'AAAA' (IPv6).
-			result = &endpoint.Endpoint{
-				DNSName:          ep.DNSName,
-				Targets:          ep.Targets,
-				RecordType:       endpoint.RecordTypeAAAA,
-				RecordTTL:        ep.RecordTTL,
-				Labels:           ep.Labels,
-				ProviderSpecific: ep.ProviderSpecific,
-				SetIdentifier:    ep.SetIdentifier,
-			}
-			ep.RecordType = endpoint.RecordTypeA
-		}
-	} else {
-		ep.DeleteProviderSpecificProperty(providerSpecificEvaluateTargetHealth)
-	}
-
-	adjustGeoProximityLocationEndpoint(ep)
-	return result
-}
-
 // if the endpoint is using geoproximity, set the bias to 0 if not set
 // this is needed to avoid unnecessary Upserts if the desired endpoint doesn't specify a bias
 func adjustGeoProximityLocationEndpoint(ep *endpoint.Endpoint) {