Check types

Author: goto-bus-stop

.github/workflows/ci.yml

@@ -20,6 +20,20 @@ jobs:
         run: npm install
       - name: Run tests
         run: npm run tests-only
+  types:
+    name: Typecheck
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout sources
+        uses: actions/checkout@v4
+      - name: Install Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
+      - name: Install dependencies
+        run: npm install
+      - name: Check types
+        run: npm run types
   lint:
     name: Lint
     runs-on: ubuntu-latest
@@ -32,5 +46,5 @@ jobs:
           node-version: lts/*
       - name: Install dependencies
         run: npm install
-      - name: Run tests
+      - name: Check style
         run: npm run lint

package.json

@@ -42,7 +42,8 @@
     "prepare": "npm run build",
     "lint": "oxlint src && dprint check",
     "tests-only": "node test/test.js",
-    "test": "npm run build && npm run tests-only && npm run lint"
+    "test": "npm run build && npm run types && npm run tests-only && npm run lint",
+    "types": "tsc -p . --noEmit"
   },
   "typings": "./dist/index.d.ts"
 }

src/Importer.ts

@@ -1,5 +1,5 @@
 import httpErrors from 'http-errors';
-import Client, { PlaylistItemResource, PlaylistResource } from './Client';
+import Client, { type PlaylistItemResource, type PlaylistResource } from './Client';
 import { getBestThumbnail, getPlaylistID, getVideos, type UwMedia } from './util';
 
 const { BadRequest, NotFound } = httpErrors;
@@ -105,7 +105,11 @@ export default class YouTubeImport {
       id: playlistID,
       maxResults: 1,
     });
-    return data.items[0];
+    const [playlist] = data.items;
+    if (playlist == null) {
+      throw new NotFound('Playlist not found.');
+    }
+    return playlist;
   }
 
   async getImportablePlaylist(url: string): Promise<{
@@ -149,11 +153,11 @@ export default class YouTubeImport {
     };
     let idOptions;
     if (match) {
-      idOptions = { id: match[1] };
+      idOptions = { id: match[1]! };
     } else {
       match = url.match(rxUserUrl);
       if (match) {
-        idOptions = { forUsername: match[1] };
+        idOptions = { forUsername: match[1]! };
       } else {
         throw new BadRequest(
           'Invalid channel URL. Please provide a direct link to the channel or '
@@ -173,7 +177,7 @@ export default class YouTubeImport {
       );
     }
 
-    const channel = data.items[0];
+    const channel = data.items[0]!;
     return {
       id: channel.id,
       title: channel.snippet.title,

src/util.ts

@@ -2,7 +2,7 @@ import getArtistTitle from 'get-artist-title';
 import getYouTubeChapters from 'get-youtube-chapters';
 import getYouTubeID from 'get-youtube-id';
 import parseIsoDuration from 'parse-iso-duration';
-import Client, { Thumbnails, VideoResource } from './Client';
+import Client, { type Thumbnails, type VideoResource } from './Client';
 
 const rxSimplePlaylistUrl = /youtube\.com\/(?:playlist|watch)\?.*?list=([a-z0-9_-]+)/i;
 const rxPlaylistID = /^([a-z0-9_-]+)$/i;
@@ -17,7 +17,7 @@ export function getPlaylistID(url: string): string | null {
 
   const match = url.match(rxSimplePlaylistUrl);
   if (match) {
-    return match[1];
+    return match[1]!;
   }
 
   return null;
@@ -93,7 +93,7 @@ function convertVideoToMedia(video: VideoResource): UwMedia {
         if (index < chapters.length - 1) {
           return {
             ...chapter,
-            end: chapters[index + 1].start,
+            end: chapters[index + 1]!.start,
           };
         }
         return {