Blocking intrusive self-promo popup on dropbox.com

[DimitrisKalaboukas]

Can anyone reproduce this issue?

#15751

The hiding filter leaves background page partially problematic and so the popup should be blocked by a scriptlet filter. The generic resetting filter:

dropbox.com##body,html:style(overflow: auto !important; position: initial !important;)

doesn’t fix it completely.

[krystian3w]

I don't think I can reproduce it, the pop-up can be cut as high as possible by checking that it has these two links:

dropbox.com##.ReactModalPortal:has(a[href*="/buy/plus"]):has(a[href*="/try/teams"])
dropbox.com##.ReactModalPortal:has(img[src*="/will/mobile-qr-code"])

The one about paid plans and a mobile app advertised with a QR code no longer pops up for me after closing with a cross or skip button - maybe they save who closed (you'd have to create a new account) or what IP you closed on (maybe fooled by Proxy/VPN/Tor).

Surely the problem will be when the site accumulates multiple modals in one React tree, I had something like that with Duolingo webpage/forum and I think I had to copy the solution from AdGuard.

[DimitrisKalaboukas]

These filters don’t make any difference. The popup should be blocked at the scriptlet level, in order not to change background page style.

[DimitrisKalaboukas]

@krystian3w Do you have a free test or real Dropbox account? The self-promo popup appears from desktop every time you open the site being logged in and probably can be prevented by a filter similar to:

dropbox.com##+js(set-session-storage-item, has_seen_interstitial, true)

which successfully prevents similar modals about downloading their mobile app. You may need to upload some files in order to trigger it.

[krystian3w]

You can't use procedural selectors in uBo scriptlets, this is the limit of the current engine and it is not worth changing without over 100+ necessary use cases: uBlockOrigin/uBlock-issues#3242

You can try to find something that makes the pop-up stand out using CSS4: https://developer.mozilla.org/en-US/docs/Web/CSS/:has, if the pop-ups only have differences in the raw text (e.g. unnecessary images/rows hidden in JS by webmaster), then you probably need to further debug the code generating the pop-up or use $replace or trusted-replace-node-text for this purpose.

[DimitrisKalaboukas]

Yeah, this one works as well:

dropbox.com##+js(trusted-click-element, .dig-Modal:has(div[data-testid="digTruncateTooltipTrigger"]) > .dig-Modal-close-btn, , 2000)

[DimitrisKalaboukas]

Also, the following commit:

AdguardTeam/AdguardFilters@c69223e

has been added to AdGuard – Annoyances – Popup Overlays list, but it hasn’t been included (yet?) in uBO’s respective list. Is it incompatible with uBO?

[stephenhawk8054]

13590e2

[krystian3w]

AdGuard cut that (replace and trusted scriptlets) at server side level even compatible with latest uBo.

[DimitrisKalaboukas]

@krystian3w The modals that can be hidden by the filters:

dropbox.com##.ReactModalPortal:has(a[href*="/buy/plus"]):has(a[href*="/try/teams"])
dropbox.com##.ReactModalPortal:has(img[src*="/will/mobile-qr-code"])

began to pop up, but I didn’t manage to create effective auto-skipping/closing filters. Could you do so?

[DimitrisKalaboukas]

Oh, yeah, I finally did it! @stephenhawk8054 Could you, please, add the following filters as well?

||www.dropbox.com/plans?_camp=*_campaign_format^
dropbox.com##+js(trusted-click-element, .ReactModalPortal button:has(.dig-1f09ta21g_21-9-0), , 1000)
dropbox.com##+js(trusted-click-element, .ReactModalPortal:has(a[href*="/buy/plus"]):has(a[href*="/try/teams"]) button[data-testid="digModalCloseButton"], , 2000)
dropbox.com##+js(trusted-click-element, .ReactModalPortal:has(img[src*="/will/mobile-qr-code"]) button, , 2000)