"trusted-click-element" - new behavior in uBO-dev (when used with optional delay)

[Procyon-b]

Since I don't know if this is a new behavior or a bug, I prefer to open a discussion.

I was playing with domain##+js(trusted-click-element, [selector],, [delay]) and noticed that in the dev build the delay seems to be ignored. The dialog is closed almost immediately even with a delay of 30s.

I have tested in uBO v1.54.0 and v1.66.4 to compare the behavior. In these builds the scriptlet works as expected.
Then I have tested in clean (and unclean) profiles in chrome and FF, with uBO-dev v1.66.5b1, and the delay is ignored.

An easy test is on perplexity:

1. better to work in an incognito/private window
2. open a tab and load https://www.perplexity.ai/
3. at some point while loading (or when loaded), a fullscreen splashscreen for "comet" appears, ignore it
4. reload the page
5. a cookie dialog appear and is replace by a small dialog for "comet" (again)
6. this filter should close it: perplexity.ai##+js(trusted-click-element, body > main > div[style^="opacity: 1;"]:has(img[src*="comet_announcement"]) button:has(svg > path[d="M18 6l-12 12 M6 6l12 12"]), , 30000)
7. To test again, clear the site's cookies and local storage and reload the tab. You restart at step 3

The filter in step 6 closes the small "comet" dialog with a delay in uBO, but not in uBO-dev

[ghajini]

Changes gorhill/uBlock@9aa91ba

[krystian3w]

Theoretically you can add an empty '' in your list for click scriptlets:

domain##+js(trusted-click-element, [selector], '', [delay])
!                                              ^^ like that

Then it works almost like the old syntax and gorhill doesn't have to analyze the popularity of the actual lack of characters or only spaces between commas or how to restore them if they are too popular.

For me, it is enough to remember not to use physical voids but an empty text string (Clicking in the "my" company app also broke that change for me and it was possible to avoid a complete rebuild with a quote and a delay at the beginning and then a selector if I need use dev build).

As for the problem with clicking beyond the 15-second limit, such a simple fix probably won't fix it.

[freezer2022]

Procyon-b:
When I test perplexity.ai##+js(trusted-click-element, '9000, body > main > div[style^="opacity: 1;"]:has(img[src*="comet_announcement"]) button:has(svg > path[d="M18 6l-12 12 M6 6l12 12"])') it waits 9s from the moment the website starts answering the url query, to click the element. But if I use 10000 and above, nothing is clicked.

It's not a bug - it's because there is a built-in 10s timeout:

gorhill/uBlock@9aa91ba :
If the last item in the list is an integer, this tells the scriplet to
override the built-in timeout value of 10s, such that the life time of
the scriptlet can now be extended beyond 10s.

This one works:
perplexity.ai##+js(trusted-click-element, '10000, body > main > div[style^="opacity: 1;"]:has(img[src*="comet_announcement"]) button:has(svg > path[d="M18 6l-12 12 M6 6l12 12"], 11000')

---

krystian3w:
Theoretically you can add an empty '' in your list for click scriptlets.
Then it works almost like the old syntax

It does not work - the delay is still not respected, and it clicks instantly.

[krystian3w]

I have an empty text string working and I have a delay of 3000 ms in the company application, voids/blanks doesn't (clicked too fast).

[Procyon-b]

@freezer2022 thank for the info.
@krystian3w the 3000ms is to low to trigger after the dialog appears anyway. For me, it appear after 7-9s (unless it's a typo and you meant 30000)

[krystian3w]

No, it's not a typo. The company application needs a delay to start “trusted-create-html” first or not to overload it when about 500 people are working (where 90% are authorized points of sale or other companies and their authorized points of sale).

[ghajini]

this was your issue

?
your filter perplexity.ai##+js(trusted-click-element, body > main > div[style^="opacity: 1;"]:has(img[src*="comet_announcement"]) button:has(svg > path[d="M18 6l-12 12 M6 6l12 12"]), , 30000)
works for me

[krystian3w]

Well, this is an interesting puzzle, especially since it crashed in two different browsers at the same time.

Maybe a similar mechanism like magic numbers is needed when the scriptlet is modified with a new syntax variant or vartags.

[gorhill]

So I used an extension to switch user agent to simulate a Windows OS, and I could reproduce a "comet" dialog in the bottom right corner. However the filter worked for me, the dialog was clicked ~2 seconds after the scriptlet was injected.

Screenshot

---

To reproduce at will, I delete the cookie pplx.visitor-id. On second visit of the site after dismissing the full page overlay in the first visit, the "comet" dialog always appear in the bottom right corner.

[freezer2022]

ghajini: this was your issue, your filter perplexity.ai##+js(trusted-click-element, body > main > div[style^="opacity: 1;"]:has(img[src*="comet_announcement"]) button:has(svg > path[d="M18 6l-12 12 M6 6l12 12"]), , 30000) works for me

gorhill: However the filter worked for me, the dialog was clicked ~2 seconds after the scriptlet was injected.

The reported issue was not "it doesn't work", the reported issue was: "it works, but doesn't respect the delay in the old syntax" . And on the screenshoots of your both, it still does not respect the 30000 delay as well, means the issue is still here for both of you.

[gorhill]

The reported issue was not "it doesn't work", the reported issue was: "it works, but doesn't respect the delay in the old syntax".

Ok, I get it now, I failed to understand correctly. I can reproduce and further fixed the scriptlet to respect the old behavior when the original syntax is used: gorhill/uBlock@f9bb6d7

[Procyon-b]

@ghajini I have focused on this is the past few days.
If you know a video capture that works on windows 8.1 (sorry, I don't have a machine with w10/11 available at the moment), I could show you the behavior in chome and FF, with different versions of uBO.

[Procyon-b]

@gorhill I'm glad that you could finally reproduce the issue.
I have the habit to jump too soon on an "issue". And I was afraid that it was the case here too. :)