Skip to content

Tick boxes not quite visible when using custom dark colours on firefox #3471

@Unixware

Description

@Unixware

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • using a new, unmodified browser profile.

Description

This is mainly a request for an accessibility enhancement.

I am using custom dark colors on Firefox, the ticks on the ublock-settings tick boxes are not visible; they are dark and only become visible when I set uBlock to 'light theme.' However, this option breaks the buttons on the extension in the toolbar. When I set the theme to 'dark,' the buttons are fine, but the ticks are no longer visible, as they are black and blend in with the dark background. I suggest implementing an inverted background for the ticks, similar to the tick boxes in Firefox's settings
thank you.

A specific URL where the issue occurs.

ublock's settings/buttons

Steps to Reproduce

  • Open Firefox and go to the settings menu.
  • Navigate to "Colors" under the "Manage Colors" section.
  • Set the text color to a light color (e.g., yellow).
  • Set the background color to a dark color (e.g., black).
  • Ensure that the drop-down list "Override the colors..." is set to "Always."
  • Check the "Website appearance" settings and confirm they are set to "Dark." (does not matter anyway)

Expected behavior

ticks on tick boxes should be visible

Actual behavior

dark theme - invisible ticks but buttons ok
10:16:21
10:15:31
light theme - visible ticks but buttons not ok
10:16:37
10:16:58

firefox's implementation of tick boxes
10:19:48

Configuration

Details
uBlock Origin: 1.61.2
Firefox: 128
filterset (summary):
 network: 118424
 cosmetic: 100331
 scriptlet: 39592
 html: 2194
listset (total-discarded, last-updated):
 removed:
  easyprivacy: null
 added:
  adguard-generic: 86032-4229, 4d.18h.54m
  adguard-mobile: 9954-61, 4d.18h.54m
  block-lan: 64-0, 11d.21h.27m
  curben-phishing: 493-0, 19h.33m
  dpollock-0: 11712-295, 4d.19h.54m
 default:
  user-filters: 35-0, never
  ublock-filters: 41162-134, 1h.14m Δ
  ublock-badware: 12229-1, 1h.14m Δ
  ublock-privacy: 1576-22, 1h.14m Δ
  ublock-unbreak: 2583-1, 1h.14m Δ
  ublock-quick-fixes: 232-4, 1h.14m Δ
  easylist: 78328-2243, 1h.14m Δ
  urlhaus-1: 20735-0, 19h.33m
  plowe-0: 3532-833, 4d.20h.54m
filterset (user): [array of 35 redacted]
trustedset:
 added: [array of 29 redacted]
switchRuleset:
 added: [array of 8 redacted]
userSettings:
 advancedUserEnabled: true
 cloudStorageEnabled: true
 colorBlindFriendly: true
 suspendUntilListsAreLoaded: false
hiddenSettings: [none]
supportStats:
 allReadyAfter: 822 ms (selfie)
 maxAssetCacheWait: 129 ms
 cacheBackend: indexedDB
 unsuspendAfter: 683 ms

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateThis issue or pull request already exists

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions