function to get data in one go in v20.25.0

[git-matrix]

const uWebSockets = require('uWebSockets.js');

const readStream = (req, res) => new Promise((resolve, reject) => {
    try {
        let data = Buffer.from('');
        res
            .onData((chunk, isLast) => {
                if (isLast)
                    resolve(Buffer.concat([data, Buffer.from(chunk)]));
                else
                    data = Buffer.concat([data, Buffer.from(chunk)]);
            }).onAborted(() => reject(''));
    } catch (err) { reject(err); };
});

uWebSockets.App()
    .post('/', async (res, req) => {
        const data = await readStream(req, res);

        console.log(JSON.parse(data));
       
        res.writeStatus('200 OK');
        res.end('OK');
    }).listen(8080, () => { });

At first tested this with v20.25.0 with Alien mode, then with v20.24.0. Both of them worked fine when I sent some Json body. But, whenever I sent a request with empty body or no content, the request get timeout.

[git-matrix]

const readStream = (req: WebRequest, res: WebResponse): Promise<Uint8Array> => new Promise((resolve, reject) => {
    const unitArray = new Uint8Array(parseFloat(req.getHeader('content-length')) || 0);

    if (unitArray.byteLength > 0 && unitArray.byteLength < 1024 * 1024 * 10) {
        let offset: number = 0; res
            .onData((data, done) => {
                unitArray
                    .set(unitArray, offset);
                offset += data.byteLength;

                if (done)
                    resolve(unitArray);
            }).onAborted(() => reject(``));
    } else
        resolve(unitArray);
});

Is this correct way?

[uNetworkingAB]

no

[uNetworkingAB]

You don't check content-length manually, just receive the chunks as they come (content-length is not the only way to get data

[uNetworkingAB]

Your code has no fast path, it always copies. Even when not needed to

[git-matrix]

What am I doing wrong? What would be fastest way to do so?

[e3dio]

const getBody = (res, req, maxSize = 1e6) => new Promise((resolve, reject) => {
   const contentLength = Number(req.getHeader('content-length'));
   if (!(contentLength > 0)) return reject('Missing or zero content-length header');
   if (contentLength > maxSize) return reject(`maxSize ${maxSize} exceeded: ${contentLength}`);
   let uint8Array, offset = 0;
   res.onAborted(() => {
      res.ab = true;
      reject('aborted');
   });
   res.onData((arrayBuffer, isLast) => {
      if (!arrayBuffer.byteLength && !isLast) return;
      const total = offset + arrayBuffer.byteLength;
      if (total > contentLength) {
         reject(`Body larger than content-length: ${contentLength}`);
         return res.close();
      }
      if (isLast && total != contentLength) return reject(`Body size ${total} != content-length ${contentLength}`);
      if (!uint8Array) {
         if (isLast) return resolve(arrayBuffer);
         uint8Array = new Uint8Array(contentLength);
      }
      uint8Array.set(new Uint8Array(arrayBuffer), offset);
      if (isLast) return resolve(uint8Array);
      offset = total;
   });
});

[git-matrix]

Is this not a performance hunt? You are converting Array Buffer to Buffer every time, rather than converting only one time.

[e3dio]

I updated the code to use Uint8Array instead of Buffer, they are faster to create

[e3dio]

I added if (!arrayBuffer.byteLength && !isLast) return; shortcut for first onData event #910

[git-matrix]

const getStream = (req: HttpRequest, res: HttpResponse, maxSize?: number): Promise<Uint8Array> => new Promise((resolve, reject) => {
    maxSize = maxSize || 1024 * 1024 * 10;
    const contentSize = parseFloat(req.getHeader('content-length'));

    if (contentSize > 0 && contentSize < maxSize) {
        let offset: number = 0, unitArray: Uint8Array;

        res
            .onAborted(() => reject(`Aborted`))
            .onData((arrayBuffer, done) => {
                if (!arrayBuffer.byteLength && !done)
                    return;

                const total = offset + arrayBuffer.byteLength;
                if (total > maxSize)
                    return reject(`Content size is greater than ${maxSize} bytes.`);
                else {
                    if (!unitArray)
                        if (done)
                            return resolve(Buffer.from(arrayBuffer));
                        else
                            unitArray = Buffer.allocUnsafe(contentSize);
                    Buffer
                        .from(arrayBuffer).copy(unitArray, offset);

                    if (done)
                        return resolve(unitArray);
                    offset = total;
                };
            });
    } else
        reject(`Content size must be between 0-${maxSize} bytes.`);
});

[uNetworkingAB]

@NexaraDev Can we go back and focus on the main issue:

But, whenever I sent a request with empty body or no content, the request get timeout.

Please explain how this relates to for instance the Upload.js example - what method, how do you trigger this failure? Curl example?

[git-matrix]

Now, I understand the mistake, I must check the byte length instead of content length.