Fix tryEnd undefined ordering

uNetworkingAB · uNetworkingAB · commit 2e78447c62d4 · 2024-12-30T08:50:41.000+01:00
diff --git a/src/HttpResponse.h b/src/HttpResponse.h
@@ -436,7 +436,8 @@ struct HttpResponse : public AsyncSocket<SSL> {
     /* Try and end the response. Returns [true, true] on success.
      * Starts a timeout in some cases. Returns [ok, hasResponded] */
     std::pair<bool, bool> tryEnd(std::string_view data, uintmax_t totalSize = 0, bool closeConnection = false) {
-        return {internalEnd(data, totalSize, true, true, closeConnection), hasResponded()};
+        bool ok = internalEnd(data, totalSize, true, true, closeConnection);
+        return {ok, hasResponded()};
     }
 
     /* Write parts of the response in chunking fashion. Starts timeout if failed. */

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,8 @@ struct HttpResponse : public AsyncSocket<SSL> {`
`436`	`436`	`/* Try and end the response. Returns [true, true] on success.`
`437`	`437`	`* Starts a timeout in some cases. Returns [ok, hasResponded] */`
`438`	`438`	`std::pair<bool, bool> tryEnd(std::string_view data, uintmax_t totalSize = 0, bool closeConnection = false) {`
`439`		`- return {internalEnd(data, totalSize, true, true, closeConnection), hasResponded()};`
	`439`	`+ bool ok = internalEnd(data, totalSize, true, true, closeConnection);`
	`440`	`+ return {ok, hasResponded()};`
`440`	`441`	`}`
`441`	`442`
`442`	`443`	`/* Write parts of the response in chunking fashion. Starts timeout if failed. */`