Commit a270fe2
committed
run mypy even if ruff fails
Because all the checks are performed in the same job and github
actions will stop at the first step failure within a job, if one of
the ruff checks (formatting or checking) fails then mypy does not run
at all, which is undesirable.
Turns out the steps have an implicit `if success()` if no [status
check function][check] (`success`, `failure`, `always`, `cancelled`)
is used to guard the step.
Thus by gating on `always` and possibly explicitly checking the
conclusion of specific checks it becomes possible to run `mypy` even
though `ruff check` failed, but not run it if *installing* mypy
failed.
[check]: https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions1 parent 63eda17 commit a270fe2
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | 18 | | |
21 | 19 | | |
22 | 20 | | |
23 | 21 | | |
24 | 22 | | |
25 | 23 | | |
| 24 | + | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| 29 | + | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
| 35 | + | |
| 36 | + | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
| 41 | + | |
38 | 42 | | |
39 | 43 | | |
40 | 44 | | |
| |||
0 commit comments