Remove dependency from ua-parser-builtins #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmmm crap I need to include a way to bump up versions now, this needs to be a .1, and I didn't think about that when setting up the hook. And since the .dev is based on the distance from the last tag it's even worse, I'm going to need to mess with |
Contributor
Author
|
Noting here before I forget: for normal releases, can probably use postN? For dev releases, not sure you can .devX.postY but maybe it doesn’t matter and that can just wait on the next dev, I’d assume people who are really strict about such things don’t use —pre releases. |
masklinn
force-pushed
the
remove-circular-dependency
branch
from
2075310 to
8752879
Compare
Turns out I did a booboo which was predictable, and if we want to track the versioning of uap-core we can't just start diverging. post-releases provide a path forwards, but was not initially predicted. Special case the existing stable releases in the script, might do something smarter eventually if necessary but...
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it). Fixes ua-parser#246
masklinn
force-pushed
the
remove-circular-dependency
branch
from
8752879 to
5dfc556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it).
Fixes #246