Check for error in response when selecting file. More informative error messages

Author: ubavic

card/apollo.go

@@ -2,6 +2,7 @@ package card
 
 import (
 	"encoding/binary"
+	"encoding/hex"
 	"fmt"
 
 	"github.com/ubavic/bas-celik/v2/document"
@@ -132,7 +133,11 @@ func (card *Apollo) selectFile(name []byte, ne uint) ([]byte, error) {
 	apu := buildAPDU(0x00, 0xA4, 0x08, 0x00, name, ne)
 	rsp, err := card.smartCard.Transmit(apu)
 	if err != nil {
-		return nil, fmt.Errorf("selecting file: %w", err)
+		return nil, fmt.Errorf("selecting file %s: %w", hex.EncodeToString(name), err)
+	}
+
+	if !responseOK(rsp) {
+		return nil, fmt.Errorf("selecting file %s: response %s", hex.EncodeToString(name), hex.EncodeToString(rsp))
 	}
 
 	return rsp, nil

card/gemalto.go

@@ -230,6 +230,10 @@ func (card *Gemalto) selectFile(name []byte, selectionMethod, selectionOption by
 		return nil, fmt.Errorf("selecting file: %w", err)
 	}
 
+	if !responseOK(rsp) {
+		return nil, fmt.Errorf("selecting file: response %s", hex.EncodeToString(rsp))
+	}
+
 	return rsp, nil
 }
 
@@ -253,7 +257,7 @@ func (card *Gemalto) InitCrypto() error {
 	}
 
 	if !responseOK(rsp) {
-		return errors.New("cryptography application not selected")
+		return fmt.Errorf("cryptography application not selected: response %s", hex.EncodeToString(rsp))
 	}
 
 	return nil
@@ -289,7 +293,7 @@ func (card *Gemalto) ChangePin(newPin, oldPin string) (int, error) {
 	}
 
 	if !responseOK(rsp) {
-		return PinTriesLeft(rsp), errors.New("verifying old pin")
+		return PinTriesLeft(rsp), fmt.Errorf("verifying old pin: response %s", hex.EncodeToString(rsp))
 	}
 
 	data := make([]byte, 0, 8)
@@ -303,7 +307,7 @@ func (card *Gemalto) ChangePin(newPin, oldPin string) (int, error) {
 	}
 
 	if !responseOK(rsp) {
-		return PinTriesLeft(rsp), errors.New("changing pin")
+		return PinTriesLeft(rsp), fmt.Errorf("verifying old pin: response %s", hex.EncodeToString(rsp))
 	}
 
 	err = card.smartCard.EndTransaction(scard.LeaveCard)

card/medical.go

@@ -2,6 +2,7 @@ package card
 
 import (
 	"encoding/binary"
+	"encoding/hex"
 	"fmt"
 	"strings"
 
@@ -57,7 +58,7 @@ func (card *MedicalCard) InitCard() error {
 	}
 
 	if !responseOK(rsp) {
-		return fmt.Errorf("initializing card: response not OK")
+		return fmt.Errorf("initializing card: response %s", hex.EncodeToString(rsp))
 	}
 
 	return nil
@@ -175,7 +176,11 @@ func (card *MedicalCard) selectFile(name []byte) ([]byte, error) {
 	apu := buildAPDU(0x00, 0xA4, 0x00, 0x00, name, 0)
 	rsp, err := card.smartCard.Transmit(apu)
 	if err != nil {
-		return nil, fmt.Errorf("selecting file: %w", err)
+		return nil, fmt.Errorf("selecting file %s: %w", hex.EncodeToString(name), err)
+	}
+
+	if !responseOK(rsp) {
+		return nil, fmt.Errorf("selecting file %s: response %s", hex.EncodeToString(name), hex.EncodeToString(rsp))
 	}
 
 	return rsp, nil

card/vehicle.go

@@ -1,6 +1,7 @@
 package card
 
 import (
+	"encoding/hex"
 	"fmt"
 
 	"github.com/ubavic/bas-celik/v2/card/ber"
@@ -268,7 +269,11 @@ func (card *VehicleCard) selectFile(name []byte) ([]byte, error) {
 
 	rsp, err := card.smartCard.Transmit(apu)
 	if err != nil {
-		return nil, fmt.Errorf("selecting file: %w", err)
+		return nil, fmt.Errorf("selecting file %s: %w", hex.EncodeToString(name), err)
+	}
+
+	if !responseOK(rsp) {
+		return nil, fmt.Errorf("selecting file %s: response %s", hex.EncodeToString(name), hex.EncodeToString(rsp))
 	}
 
 	return rsp, nil