Skip to content

Commit a925f06

Browse files
authored
Merge pull request #620 from ubc-biztech/email-bypass
Add more email bypasses; do direct user check to avoid pre-fill bug
2 parents 9794d05 + 2d19613 commit a925f06

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

.github/workflows/firebase-hosting-merge.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ jobs:
3636
REACT_APP_BYPASS_EMAIL_5: '${{ secrets.REACT_APP_BYPASS_EMAIL_5 }}'
3737
REACT_APP_BYPASS_EMAIL_6: '${{ secrets.REACT_APP_BYPASS_EMAIL_6 }}'
3838
REACT_APP_BYPASS_EMAIL_7: '${{ secrets.REACT_APP_BYPASS_EMAIL_7 }}'
39+
REACT_APP_BYPASS_EMAIL_8: '${{ secrets.REACT_APP_BYPASS_EMAIL_8 }}'
40+
REACT_APP_BYPASS_EMAIL_9: '${{ secrets.REACT_APP_BYPASS_EMAIL_9 }}'
41+
REACT_APP_BYPASS_EMAIL_10: '${{ secrets.REACT_APP_BYPASS_EMAIL_10 }}'
3942

4043
- name: Dev Firebase Deploy
4144
if: github.ref == 'refs/heads/dev'
@@ -68,6 +71,9 @@ jobs:
6871
REACT_APP_BYPASS_EMAIL_5: '${{ secrets.REACT_APP_BYPASS_EMAIL_5 }}'
6972
REACT_APP_BYPASS_EMAIL_6: '${{ secrets.REACT_APP_BYPASS_EMAIL_6 }}'
7073
REACT_APP_BYPASS_EMAIL_7: '${{ secrets.REACT_APP_BYPASS_EMAIL_7 }}'
74+
REACT_APP_BYPASS_EMAIL_8: '${{ secrets.REACT_APP_BYPASS_EMAIL_8 }}'
75+
REACT_APP_BYPASS_EMAIL_9: '${{ secrets.REACT_APP_BYPASS_EMAIL_9 }}'
76+
REACT_APP_BYPASS_EMAIL_10: '${{ secrets.REACT_APP_BYPASS_EMAIL_10 }}'
7177

7278
- name: Prod Firebase Deploy
7379
if: github.ref == 'refs/heads/master'

.github/workflows/firebase-hosting-pull-request.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ jobs:
3535
REACT_APP_BYPASS_EMAIL_5: '${{ secrets.REACT_APP_BYPASS_EMAIL_5 }}'
3636
REACT_APP_BYPASS_EMAIL_6: '${{ secrets.REACT_APP_BYPASS_EMAIL_6 }}'
3737
REACT_APP_BYPASS_EMAIL_7: '${{ secrets.REACT_APP_BYPASS_EMAIL_7 }}'
38+
REACT_APP_BYPASS_EMAIL_8: '${{ secrets.REACT_APP_BYPASS_EMAIL_8 }}'
39+
REACT_APP_BYPASS_EMAIL_9: '${{ secrets.REACT_APP_BYPASS_EMAIL_9 }}'
40+
REACT_APP_BYPASS_EMAIL_10: '${{ secrets.REACT_APP_BYPASS_EMAIL_10 }}'
3841

3942
- name: Dev Firebase Preview
4043
if: github.event.pull_request.base.ref == 'dev'
@@ -66,6 +69,9 @@ jobs:
6669
REACT_APP_BYPASS_EMAIL_5: '${{ secrets.REACT_APP_BYPASS_EMAIL_5 }}'
6770
REACT_APP_BYPASS_EMAIL_6: '${{ secrets.REACT_APP_BYPASS_EMAIL_6 }}'
6871
REACT_APP_BYPASS_EMAIL_7: '${{ secrets.REACT_APP_BYPASS_EMAIL_7 }}'
72+
REACT_APP_BYPASS_EMAIL_8: '${{ secrets.REACT_APP_BYPASS_EMAIL_8 }}'
73+
REACT_APP_BYPASS_EMAIL_9: '${{ secrets.REACT_APP_BYPASS_EMAIL_9 }}'
74+
REACT_APP_BYPASS_EMAIL_10: '${{ secrets.REACT_APP_BYPASS_EMAIL_10 }}'
6975

7076
- name: Prod Firebase Preview
7177
if: github.event.pull_request.base.ref == 'master'

src/pages/admin/DynamicForm/FormRegister.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,10 @@ const FormRegister = (props) => {
10581058
process.env.REACT_APP_BYPASS_EMAIL_4,
10591059
process.env.REACT_APP_BYPASS_EMAIL_5,
10601060
process.env.REACT_APP_BYPASS_EMAIL_6,
1061-
process.env.REACT_APP_BYPASS_EMAIL_7
1061+
process.env.REACT_APP_BYPASS_EMAIL_7,
1062+
process.env.REACT_APP_BYPASS_EMAIL_8,
1063+
process.env.REACT_APP_BYPASS_EMAIL_9,
1064+
process.env.REACT_APP_BYPASS_EMAIL_10
10621065
].filter(Boolean);
10631066
return bypassEmails.includes(email?.toLowerCase());
10641067
};
@@ -1343,7 +1346,7 @@ const FormRegister = (props) => {
13431346
<div style={styles.section}>{loadQuestions()}</div>
13441347
<div style={styles.divider}></div>
13451348
<div style={styles.submitSection}>
1346-
{!user?.admin && !isSpecialBypassEmail(responseData[0]) &&
1349+
{!user?.admin && !isSpecialBypassEmail(user?.email) && !isSpecialBypassEmail(responseData[0]) &&
13471350
((user?.isMember && currEvent.pricing?.members > 0) ||
13481351
(!user?.isMember && currEvent.pricing?.nonMembers)) ? (
13491352
currEvent.isApplicationBased ? (

0 commit comments

Comments
 (0)