Skip to content

Commit 7e1523c

Browse files
committed
Use header for github auth and strip \r for validation
1 parent a1cb6f0 commit 7e1523c

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

github2gitlab/main.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -443,13 +443,22 @@ def get(self, url, query, cache):
443443
payloads_file = (self.tmpdir + "/" +
444444
hashlib.sha1(url.encode('utf-8')).hexdigest() +
445445
".json")
446+
if 'access_token' in query:
447+
headers = {"Accept": "application/vnd.github.v3+json",
448+
"Authorization": f'token {query["access_token"]}'
449+
}
450+
q = query
451+
del q['access_token']
452+
else:
453+
headers = None
454+
q = query
446455
if (not cache or not os.access(payloads_file, 0) or
447456
time.time() - os.stat(payloads_file).st_mtime > 24 * 60 * 60):
448457
payloads = []
449-
next_query = query
458+
next_query = q
450459
while next_query:
451460
log.debug(str(next_query))
452-
result = requests.get(url, params=next_query)
461+
result = requests.get(url, params=next_query, headers=headers)
453462
payloads += result.json()
454463
next_query = None
455464
for link in result.headers.get('Link', '').split(','):
@@ -459,7 +468,7 @@ def get(self, url, query, cache):
459468
parsed_url = parse.urlparse(m.group(1))
460469
# append query in case it was not preserved
461470
# (gitlab has that problem)
462-
next_query = query
471+
next_query = q
463472
next_query.update(
464473
dict(parse.parse_qsl(parsed_url.query))
465474
)
@@ -550,7 +559,7 @@ def verify_merge_update(self, updates, result):
550559
key = 'state'
551560
value = self.STATE_EVENT2MERGE_STATE[updates['state_event']]
552561
result_value = result.get(key) or ''
553-
if value.strip() != result_value.strip():
562+
if value.strip().replace('\r', '') != result_value.strip():
554563
url = (g['host'] + "/" + parse.unquote(g['repo']) + "/" +
555564
"merge_requests/" + str(result['iid']))
556565
raise ValueError("{url}: {key} value expected to be {value}"

0 commit comments

Comments
 (0)