Skip to content
This repository was archived by the owner on Feb 18, 2021. It is now read-only.

ConcurrentMap size calculation is wrong? #338

@wxing1292

Description

@wxing1292

Please see the followings:

  1. Remove decrement the counter with no checking of whether key exists or not:
    https://github.com/uber/cherami-server/blob/master/common/concurrentmap.go#L173

  2. Put increase the counter with no checking of whether key exists or not:
    https://github.com/uber/cherami-server/blob/master/common/concurrentmap.go#L148

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions