Peer selection not selecting moe instances with both incoming and outgoing connections

[prashantv]

While introspecting moe in dca1, we found that a single Hyperbahn node (hyperbahn09-dca1) was not sending any calls to a specific instance of moe. Upon debugging, the only difference between this node and other nodes was that this node had both "in" and "out" connections.

  "10.25.13.4:54135": {
    "connected": {
      "in": true,
      "out": true
    },
    "identified": {
      "in": true,
      "out": true
    },
    "serviceNames": [
      "moe"
    ]
  },
  "10.26.46.21:43397": {
    "connected": {
      "in": false,
      "out": true
    },
    "identified": {
      "in": false,
      "out": true
    },
    "serviceNames": [
      "moe"
    ]

This might be a bug in the peer selection logic.