Merge pull request #18 from uber/expose-errors

Expose errors when ringpop-admin cannot access members

Author: jwolski2

count.js

@@ -69,6 +69,11 @@ function main() {
 
         var cluster = clusterManager.getClusterAt(0);
 
+        if (!cluster) {
+            console.error('Error: no members in the cluster could be reached');
+            process.exit(1);
+        }
+
         if (program.members) {
             console.log(cluster.getNodeCount());
             process.exit();

lib/cluster.js

@@ -138,7 +138,7 @@ Cluster.prototype.fetchStats = function fetchStats(callback) {
             statsObj.address = memberAddr;
 
             if (err) {
-                next(null, statsObj);
+                next(err, statsObj);
                 return;
             }
 

list.js

@@ -62,6 +62,11 @@ function main() {
 
         var cluster = clusterManager.getClusterAt(0);
 
+        if (!cluster) {
+            console.error('Error: no members in the cluster could be reached');
+            process.exit(1);
+        }
+
         if (program.members) {
             printSorted(cluster.getMemberAddrs());
             process.exit();

status.js

@@ -44,6 +44,10 @@ function main() {
 
         var table = createTable([]);
         var cluster = clusterManager.getClusterAt(0);
+        if (!cluster) {
+            console.error('Error: no members in the cluster could be reached');
+            process.exit(1);
+        }
         cluster.membership.forEach(function each(member) {
             table.push([member.address, member.status]);
         });