Merge pull request #24 from uber/ws-remove-bloated-error-output

remove the printing of connection errors. Errors are expected because…

Author: CorgiMan

checksums.js

@@ -52,6 +52,8 @@ function main() {
         var checksums = reduceStatsToChecksums(clusterManager.allStats);
         var checksumsTable = createChecksumsTable(checksums);
         console.log(checksumsTable.toString());
+
+        clusterManager.printConnectionErrorMsg();
         process.exit();
     });
 }

count.js

@@ -59,6 +59,7 @@ function main() {
         var partitionCount = clusterManager.getPartitionCount();
         if (program.partitions) {
             console.log(partitionCount);
+            clusterManager.printConnectionErrorMsg();
             process.exit(0);
         }
 
@@ -76,11 +77,13 @@ function main() {
 
         if (program.members) {
             console.log(cluster.getNodeCount());
+            clusterManager.printConnectionErrorMsg();
             process.exit();
         }
 
         if (program.hosts) {
             console.log(cluster.getHostCount());
+            clusterManager.printConnectionErrorMsg();
             process.exit();
         }
     });

dump.js

@@ -73,6 +73,7 @@ function main() {
             process.exit(1);
         }
 
+        clusterManager.printConnectionErrorMsg();
         process.exit();
     }
 }

lib/cluster.js

@@ -47,6 +47,7 @@ function Cluster(opts) {
     this.lastDownloadTime = null;
     this.lastFetchTime = null;
     this.dumpTo = opts.dumpTo;
+    this.connectionErrorCount = 0;
 }
 
 Cluster.prototype.getPartitionAt = function getPartitionAt(index) {
@@ -90,14 +91,21 @@ Cluster.prototype.getSeedList = function getSeedList(callback) {
     discover(this.discoveryUri, callback);
 };
 
+Cluster.prototype.printConnectionErrorMsg = function printConnectionErrorMsg() {
+    var count = this.connectionErrorCount;
+    if (count > 0) {
+        console.error('Failed to connect to %d nodes.', count);
+    }
+};
+
 Cluster.prototype.fetchStats = function fetchStats(callback) {
     var self = this;
 
     // Reset with every fetch
     this.partitions = {};
-
     this.lastFetchTime = new Date().toISOString();
     var downloadTime = Date.now();
+    this.connectionErrorCount = 0;
 
     var foundMembers = {};
     var allStats = [];
@@ -191,7 +199,7 @@ Cluster.prototype.fetchStats = function fetchStats(callback) {
             foundMembers[memberAddr] = true;
             fetchQueue.push(memberAddr, function onStatsFetched(err, stats) {
                 if (err) {
-                    console.error('Error while fetching node stats:', err);
+                    self.connectionErrorCount++;
                     return;
                 }
 

list.js

@@ -69,11 +69,13 @@ function main() {
 
         if (program.members) {
             printSorted(cluster.getMemberAddrs());
+            clusterManager.printConnectionErrorMsg();
             process.exit();
         }
 
         if (program.hosts) {
             printSorted(cluster.getHostAddrs());
+            clusterManager.printConnectionErrorMsg();
             process.exit();
         }
     });

lookup.js

@@ -60,6 +60,7 @@ function main() {
         }
 
         console.log(res.dest);
+        clusterManager.printConnectionErrorMsg();
         process.exit();
     });
 }

partitions.js

@@ -64,6 +64,8 @@ function main() {
             ]);
         });
         console.log(table.toString());
+
+        clusterManager.printConnectionErrorMsg();
         process.exit();
     });
 }

status.js

@@ -78,6 +78,7 @@ function main() {
                     getDampScoreRange(cluster.allStats, member)]);
             });
         });
+        cluster.printConnectionErrorMsg();
         process.exit();
     });
 }

tests/count.t

@@ -2,8 +2,10 @@ Test count success:
 
   $  ringpop-admin count -m 127.0.0.1:3000
   5
+
   $  ringpop-admin count -h 127.0.0.1:3000
   1
+
   $  ringpop-admin count -p 127.0.0.1:3000
   1
 

tests/list.t

@@ -2,6 +2,7 @@ Test list command success:
 
   $  ringpop-admin list -h 127.0.0.1:3000
   127.0.0.1
+
   $  ringpop-admin list -m 127.0.0.1:3000
   127.0.0.1:3000
   127.0.0.1:3001
@@ -29,4 +30,4 @@ With bootstrap file:
   127.0.0.1:3001
   127.0.0.1:3002
   127.0.0.1:3003
-  127.0.0.1:3004
+  127.0.0.1:3004