Commit 80fbdc9
authored
Refactor ContractsTests to use Java text blocks (#1435)
Following up on my previous PR and the goal of issue #1425, I have
refactored ContractsTests.java.
- Migrated test data from external files to inline text blocks using
addSourceLines.
- Deleted physical test files: CheckContractPositiveCases.java and
CheckContractNegativeCases.java.
- Removed unnecessary @SuppressWarnings("deprecation") annotations.
- Part of the ongoing effort to modernize tests (#1425).
Thank you for contributing to NullAway!
Please note that once you click "Create Pull Request" you will be asked
to sign our [Uber Contributor License
Agreement](https://cla-assistant.io/uber/NullAway) via [CLA
assistant](https://cla-assistant.io/).
Before pressing the "Create Pull Request" button, please provide the
following:
- [x] A description about what and why you are contributing, even if
it's trivial.
- [x] The issue number(s) or PR number(s) in the description if you are
contributing in response to those.
- [x] If applicable, unit tests.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Tests**
* Consolidated external test-data into inline test cases within the test
suite for simpler maintenance and clearer test flow.
* Removed separate public test-data classes that previously existed as
external resources.
* Dropped a deprecation-suppression annotation from the public test
class to reflect current warnings handling.
<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent 4b4d1e8 commit 80fbdc9
File tree
3 files changed
+88
-140
lines changed- nullaway/src/test
- java/com/uber/nullaway
- resources/com/uber/nullaway/testdata
3 files changed
+88
-140
lines changedLines changed: 88 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
17 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
18 | 73 | | |
19 | 74 | | |
20 | 75 | | |
| |||
54 | 109 | | |
55 | 110 | | |
56 | 111 | | |
57 | | - | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
58 | 143 | | |
59 | 144 | | |
60 | 145 | | |
| |||
Lines changed: 0 additions & 55 deletions
This file was deleted.
Lines changed: 0 additions & 82 deletions
This file was deleted.
0 commit comments