Fix tests and javadocs

Author: Isaac Brodsky

src/main/java/com/uber/h3core/H3Core.java

@@ -980,8 +980,8 @@ public double cellArea(String h3Address, AreaUnit unit) {
     /**
      * Calculates the area of the given H3 cell.
      *
-     * @param h3Address Cell to find the area of.
-     * @param unit      Unit to calculate the area in.
+     * @param h3   Cell to find the area of.
+     * @param unit Unit to calculate the area in.
      * @return Cell area in the given units.
      */
     public double cellArea(long h3, AreaUnit unit) {
@@ -1020,30 +1020,30 @@ else if (unit == LengthUnit.m)
     }
 
     /**
-     * Calculate the edge length of the given H3 cell.
+     * Calculate the edge length of the given H3 edge.
      *
-     * @param h3Address Cell to find the edge length of.
-     * @param unit      Unit of measure to use.
-     * @return Edge length of the given cell.
+     * @param edgeAddress Edge to find the edge length of.
+     * @param unit        Unit of measure to use.
+     * @return Length of the given edge.
      */
-    public double exactEdgeLength(String h3Address, LengthUnit unit) {
-        return exactEdgeLength(stringToH3(h3Address), unit);
+    public double exactEdgeLength(String edgeAddress, LengthUnit unit) {
+        return exactEdgeLength(stringToH3(edgeAddress), unit);
     }
 
     /**
-     * Calculate the edge length of the given H3 cell.
+     * Calculate the edge length of the given H3 edge.
      *
-     * @param h3Address Cell to find the edge length of.
-     * @param unit      Unit of measure to use.
-     * @return Edge length of the given cell.
+     * @param edge Edge to find the edge length of.
+     * @param unit Unit of measure to use.
+     * @return Length of the given edge.
      */
-    public double exactEdgeLength(long h3, LengthUnit unit) {
+    public double exactEdgeLength(long edge, LengthUnit unit) {
         if (unit == LengthUnit.rads)
-            return h3Api.exactEdgeLengthRads(h3);
+            return h3Api.exactEdgeLengthRads(edge);
         else if (unit == LengthUnit.km)
-            return h3Api.exactEdgeLengthKm(h3);
+            return h3Api.exactEdgeLengthKm(edge);
         else if (unit == LengthUnit.m)
-            return h3Api.exactEdgeLengthM(h3);
+            return h3Api.exactEdgeLengthM(edge);
         else
             throw new IllegalArgumentException(String.format("Invalid unit: %s", unit));
     }

src/test/java/com/uber/h3core/TestH3Core.java

@@ -151,25 +151,28 @@ public void testCellArea() {
     @Test
     public void testExactEdgeLength() {
         for (int res = 0; res <= 15; res++) {
-            String cellAddress = h3.geoToH3Address(0, 0, res);
             long cell = h3.geoToH3(0, 0, res);
 
-            double areaAddressM = h3.exactEdgeLength(cellAddress, LengthUnit.m);
-            double areaAddressKm = h3.exactEdgeLength(cellAddress, LengthUnit.km);
-            double areaAddressRads = h3.exactEdgeLength(cellAddress, LengthUnit.rads);
-            double areaM = h3.exactEdgeLength(cell, LengthUnit.m);
-            double areaKm = h3.exactEdgeLength(cell, LengthUnit.km);
-            double areaRads = h3.exactEdgeLength(cell, LengthUnit.rads);
-
-            // Only asserts some properties of the functions that the edge lengths
-            // should have certain relationships to each other, test isn't specific
-            // to a cell's actual values.
-            assertTrue("edge length should match expectation", areaAddressRads > 0);
-            assertEquals("rads edge length should agree", areaAddressRads, areaRads, EPSILON);
-            assertEquals("km edge length should agree", areaAddressKm, areaKm, EPSILON);
-            assertEquals("m edge length should agree", areaAddressM, areaM, EPSILON);
-            assertTrue("m length greater than km length", areaM > areaKm);
-            assertTrue("km length greater than rads length", areaKm > areaRads);
+            for (long edge : h3.getH3UnidirectionalEdgesFromHexagon(cell)) {
+                String edgeAddress = h3.h3ToString(edge);
+
+                double areaAddressM = h3.exactEdgeLength(edgeAddress, LengthUnit.m);
+                double areaAddressKm = h3.exactEdgeLength(edgeAddress, LengthUnit.km);
+                double areaAddressRads = h3.exactEdgeLength(edgeAddress, LengthUnit.rads);
+                double areaM = h3.exactEdgeLength(edge, LengthUnit.m);
+                double areaKm = h3.exactEdgeLength(edge, LengthUnit.km);
+                double areaRads = h3.exactEdgeLength(edge, LengthUnit.rads);
+
+                // Only asserts some properties of the functions that the edge lengths
+                // should have certain relationships to each other, test isn't specific
+                // to a cell's actual values.
+                assertTrue("edge length should match expectation", areaAddressRads > 0);
+                assertEquals("rads edge length should agree", areaAddressRads, areaRads, EPSILON);
+                assertEquals("km edge length should agree", areaAddressKm, areaKm, EPSILON);
+                assertEquals("m edge length should agree", areaAddressM, areaM, EPSILON);
+                assertTrue("m length greater than km length", areaM > areaKm);
+                assertTrue("km length greater than rads length", areaKm > areaRads);
+            }
         }
     }