change per review

Author: isaacbrodsky

.github/workflows/release.yml

@@ -13,7 +13,7 @@ on:
       - "v*"
 
 jobs:
-  # Corresponsd to tests in tests.yml
+  # Corresponds to tests in tests.yml
   build-with-docker:
     name: Build ${{ matrix.dockcross-only }} (Dockcross)
     runs-on: ${{ matrix.os }}
@@ -148,15 +148,14 @@ jobs:
           if [ -n "$VERSION_INPUT" ]; then
           RELEASE_VERSION="$VERSION_INPUT"
           else
-          # Read version from build.gradle.kts or gradle.properties
-          RELEASE_VERSION=$(grep -E 'version\s*=' build.gradle.kts | sed -E 's/.*\"(.+)-SNAPSHOT\".*/\1/')
+          RELEASE_VERSION=$(grep -E 'version\s*=' gradle.properties | sed -E 's/.*\"(.+)-SNAPSHOT\".*/\1/')
           fi
           echo "RELEASE_VERSION=$RELEASE_VERSION" >> $GITHUB_ENV
 
       - name: Remove -SNAPSHOT suffix (prepare release version)
         if: ${{ github.event_name == 'workflow_dispatch' }}
         run: |
-          sed -i -E "s/${RELEASE_VERSION}-SNAPSHOT/$RELEASE_VERSION/" build.gradle.kts gradle.properties || true
+          sed -i -E "s/${RELEASE_VERSION}-SNAPSHOT/$RELEASE_VERSION/" gradle.properties || true
           git config user.name "github-actions"
           git config user.email "[email protected]"
           git commit -am "chore: release $RELEASE_VERSION [skip ci]"
@@ -213,11 +212,12 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Bump to next snapshot version
+        if: ${{ github.event_name != 'workflow_dispatch' }}
         run: |
           # Bump minor version (for example) and append -SNAPSHOT for continued development
           NEXT_VERSION=$(echo $RELEASE_VERSION | awk -F. '{$NF += 1; OFS="."; print $0}')  # increment last segment
           NEXT_VERSION="$NEXT_VERSION-SNAPSHOT"
-          sed -i -E "s/$RELEASE_VERSION/$NEXT_VERSION/" build.gradle.kts gradle.properties || true
+          sed -i -E "s/$RELEASE_VERSION/$NEXT_VERSION/" gradle.properties || true
           git config user.name "github-actions"
           git config user.email "[email protected]"
           git commit -am "chore: start next development cycle $NEXT_VERSION [skip ci]"

docs/releasing.md

@@ -2,6 +2,10 @@
 
 The H3-Java library is published to Maven Central via OSSRH.
 
+The release is triggered via GitHub Actions, when a tag of the form `v1.2.3` is pushed, or via workflow dispatch. The release workflow handles all parts of the release.
+
+## Old instructions for manual releasing
+
 You must be a member of the `com.uber` group to release the library via OSSRH. You must have a [signing key](http://central.sonatype.org/pages/working-with-pgp-signatures.html) setup, and you must have your OSSRH username and password in the appropriate [Maven settings file](http://central.sonatype.org/pages/apache-maven.html).
 
 Release builds pull artifacts from Github Actions. This is needed so that the deployed artifact contains all supported operating system/architecture combinations. (In particular, Mac OS artifacts must be built natively.) In order to release, there must be a completed build of the Git commit to release on Github. The build must be less than 30 days old, as artifacts are only kept for that time.
@@ -13,14 +17,14 @@ Release builds pull artifacts from Github Actions. This is needed so that the de
 5. If this looks good, close and release the build in [Sonatype Nexus Manager](https://oss.sonatype.org/).
 6. Update `CHANGELOG.md` to have an Unreleased section, and commit. The release is now done and development can resume from this point.
 
-## Troubleshooting
+### Troubleshooting
 
-### Dependencies for `pull-from-github.sh`
+#### Dependencies for `pull-from-github.sh`
 
 * You should install the [Github CLI](https://cli.github.com) and authenticate with it first. You may need to use a personal access token (classic) with workflows scope.
 * `jq`
 
-### gpg: signing failed: Inappropriate ioctl for device
+#### gpg: signing failed: Inappropriate ioctl for device
 
 Per [StackOverflow](https://stackoverflow.com/questions/57591432/gpg-signing-failed-inappropriate-ioctl-for-device-on-macos-with-maven), run the following before `mvn release:perform`: