Skip to content

Commit c796b0e

Browse files
committed
release followup: glibc, android 16kb, release process
1 parent 92055e3 commit c796b0e

File tree

6 files changed

+37
-32
lines changed

6 files changed

+37
-32
lines changed

.github/workflows/release.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
strategy:
2222
matrix:
23-
os: [ubuntu-latest]
23+
os: [ubuntu-22.04]
2424
java-distribution: [adopt]
2525
java-version: [11]
2626
dockcross-only:
@@ -122,7 +122,7 @@ jobs:
122122
if-no-files-found: error
123123

124124
release:
125-
runs-on: ubuntu-latest
125+
runs-on: ubuntu-22.04
126126
permissions:
127127
contents: write # allow pushing commits/tags
128128

@@ -211,14 +211,15 @@ jobs:
211211
env:
212212
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
213213

214-
- name: Bump to next snapshot version
215-
if: ${{ github.event_name != 'workflow_dispatch' }}
216-
run: |
217-
# Bump minor version (for example) and append -SNAPSHOT for continued development
218-
NEXT_VERSION=$(echo $RELEASE_VERSION | awk -F. -v OFS="." '{$NF += 1; print $0}') # increment last segment
219-
NEXT_VERSION="$NEXT_VERSION-SNAPSHOT"
220-
sed -i -E "s/$RELEASE_VERSION/$NEXT_VERSION/" gradle.properties || true
221-
git config user.name "github-actions"
222-
git config user.email "[email protected]"
223-
git commit -am "chore: start next development cycle $NEXT_VERSION [skip ci]"
224-
git push origin HEAD:master
214+
# This doesn't work because we don't permit pushes directly to main.
215+
# - name: Bump to next snapshot version
216+
# if: ${{ github.event_name != 'workflow_dispatch' }}
217+
# run: |
218+
# # Bump minor version (for example) and append -SNAPSHOT for continued development
219+
# NEXT_VERSION=$(echo $RELEASE_VERSION | awk -F. -v OFS="." '{$NF += 1; print $0}') # increment last segment
220+
# NEXT_VERSION="$NEXT_VERSION-SNAPSHOT"
221+
# sed -i -E "s/$RELEASE_VERSION/$NEXT_VERSION/" gradle.properties || true
222+
# git config user.name "github-actions"
223+
# git config user.email "[email protected]"
224+
# git commit -am "chore: start next development cycle $NEXT_VERSION [skip ci]"
225+
# git push origin HEAD:master

.github/workflows/tests.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
os: [ubuntu-latest]
19+
os: [ubuntu-22.04]
2020
java-distribution: [adopt]
2121
java-version: [11, 17, 21, 22]
2222
dockcross-only: ["android-arm", "android-arm64", "linux-arm64", "linux-armv5", "linux-armv7", "linux-s390x", "linux-ppc64le", "linux-x64", "linux-x86", "windows-static-x64", "windows-static-x86"]
@@ -45,9 +45,9 @@ jobs:
4545
restore-keys: |
4646
${{ runner.os }}-gradle-
4747
48-
# - name: Format check
49-
# if: ${{ matrix.java-version != 8 }}
50-
# run: ./gradlew spotlessCheck
48+
- name: Format check
49+
if: ${{ matrix.java-version != 11 }}
50+
run: ./gradlew spotlessCheck
5151

5252
- name: Tests
5353
run: ./gradlew clean test -Ph3SystemPrune=true "-Ph3DockcrossOnly=${{ matrix.dockcross-only }}"
@@ -73,7 +73,7 @@ jobs:
7373

7474
strategy:
7575
matrix:
76-
os: [ubuntu-latest]
76+
os: [ubuntu-22.04]
7777
java-distribution: [adopt]
7878
java-version: [21]
7979
dockcross-tag: ["latest"]
@@ -161,7 +161,7 @@ jobs:
161161

162162
strategy:
163163
matrix:
164-
os: [ubuntu-latest]
164+
os: [ubuntu-22.04]
165165
java-distribution: [adopt]
166166
java-version: [21]
167167

@@ -204,7 +204,7 @@ jobs:
204204

205205
strategy:
206206
matrix:
207-
os: [ubuntu-latest]
207+
os: [ubuntu-22.04]
208208
java-distribution: [adopt]
209209
java-version: [11]
210210

@@ -260,7 +260,7 @@ jobs:
260260

261261
strategy:
262262
matrix:
263-
os: [ ubuntu-latest ]
263+
os: [ ubuntu-22.04 ]
264264
java-distribution: [ graalvm ]
265265
java-version: [ 21 ]
266266

.github/workflows/website.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
deploy-website:
1111
name: Deploy website
12-
runs-on: ubuntu-latest
12+
runs-on: ubuntu-22.04
1313

1414
steps:
1515
- uses: actions/checkout@v4

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@ The public API of this library consists of the public functions declared in
55
file [H3Core.java](./src/main/java/com/uber/h3core/H3Core.java), and support
66
for the Linux x64 and Darwin x64 platforms.
77

8-
## [4.3.0] - 2025-06-26
8+
## Unreleased Changes
9+
### Changed
10+
- Reverted Ubuntu build to 22.04 for older glibc compatibility.
11+
- Upgraded dockcross version for Android 16kb support.
12+
13+
## [4.3.0] - 2025-08-21
914
### Added
1015
- `polygonToCellsExperimental` functions from H3 v4.2.0. (#163)
1116
- `gridRing` function from H3 v4.3.0. (#169)

build.gradle

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ plugins {
1515
id 'signing'
1616
id 'jacoco'
1717
// id 'com.github.spotbugs' version '5.2.1'
18-
// TODO: Requires Java 11
19-
// id 'com.diffplug.spotless' version '6.25.0'
18+
id 'com.diffplug.spotless' version '7.2.1'
2019
id 'com.github.nbaztec.coveralls-jacoco' version '1.2.20'
2120
id 'com.vanniktech.maven.publish' version '0.34.0'
2221
}
@@ -52,7 +51,7 @@ ext {
5251
h3GitRemote = project.findProperty('h3GitRemote') ?: 'https://github.com/uber/h3.git'
5352
h3UseDocker = project.findProperty('h3UseDocker') ?: 'true'
5453
h3SystemPrune = project.findProperty('h3SystemPrune') ?: 'false'
55-
h3DockcrossTag = project.findProperty('h3DockcrossTag') ?: '20240812-60fa1b0'
54+
h3DockcrossTag = project.findProperty('h3DockcrossTag') ?: '20250818-0a27819'
5655
h3DockcrossOnly = project.findProperty('h3DockcrossOnly') ?: ''
5756
h3GithubArtifactsUse = project.findProperty('h3GithubArtifactsUse') ?: 'false'
5857
h3GithubArtifactsByRun = project.findProperty('h3GithubArtifactsByRun') ?: ''
@@ -91,11 +90,11 @@ test {
9190
// finalizedBy jacocoTestReport
9291
}
9392

94-
// spotless {
95-
// java {
96-
// googleJavaFormat()
97-
// }
98-
// }
93+
spotless {
94+
java {
95+
googleJavaFormat()
96+
}
97+
}
9998

10099
jacoco {
101100
toolVersion = '0.8.12'

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55
org.gradle.configuration-cache=false
66

77
# No spaces on the following line, needed by release.yml:
8-
version=4.3.0
8+
version=4.3.1-SNAPSHOT
99

0 commit comments

Comments
 (0)