Skip to content

Commit e78463c

Browse files
authored
freebsd build instructions updates (#120)
* freebsd build instructions updates * cover gridDisk too large exception
1 parent b89cac8 commit e78463c

File tree

4 files changed

+10
-1
lines changed

4 files changed

+10
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Additional information on how the build process works is available in the [build
8686

8787
```sh
8888
# To install build dependencies
89-
sudo pkg install openjdk11 maven33 cmake
89+
sudo pkg install openjdk11 maven cmake bash
9090
# Ensure /usr/local/openjdk11/bin is on your path
9191
```
9292

src/test/java/com/uber/h3core/TestH3CoreLoader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public void testDetectOs() {
3030
assertEquals(H3CoreLoader.OperatingSystem.DARWIN, H3CoreLoader.detectOs("vendor", "Mac OS X"));
3131
assertEquals(H3CoreLoader.OperatingSystem.WINDOWS, H3CoreLoader.detectOs("vendor", "Windows"));
3232
assertEquals(H3CoreLoader.OperatingSystem.LINUX, H3CoreLoader.detectOs("vendor", "Linux"));
33+
assertEquals(H3CoreLoader.OperatingSystem.FREEBSD, H3CoreLoader.detectOs("vendor", "FreeBSD"));
3334

3435
assertEquals(
3536
H3CoreLoader.OperatingSystem.LINUX, H3CoreLoader.detectOs("vendor", "anything else"));

src/test/java/com/uber/h3core/TestH3CoreLoaderLocale.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public void testDetectOs() {
5050
H3CoreLoader.OperatingSystem.ANDROID, H3CoreLoader.detectOs("ANDROID", "anything"));
5151
assertEquals(H3CoreLoader.OperatingSystem.WINDOWS, H3CoreLoader.detectOs("vendor", "WINDOWS"));
5252
assertEquals(H3CoreLoader.OperatingSystem.LINUX, H3CoreLoader.detectOs("vendor", "LINUX"));
53+
assertEquals(H3CoreLoader.OperatingSystem.FREEBSD, H3CoreLoader.detectOs("vendor", "FREEBSD"));
5354

5455
assertEquals(
5556
H3CoreLoader.OperatingSystem.LINUX, H3CoreLoader.detectOs("vendor", "anything else"));

src/test/java/com/uber/h3core/TestTraversal.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,13 @@ public void testKringLarge() {
8080
assertEquals(expectedCount, hexagons.size());
8181
}
8282

83+
@Test(expected = IllegalArgumentException.class)
84+
public void testKringTooLarge() {
85+
int k = 13780510;
86+
// Cannot be materialized into Java because the maximum array size is INT32_MAX
87+
h3.gridDisk(h3.latLngToCell(0, 0, 15), k);
88+
}
89+
8390
@Test
8491
public void testKringPentagon() {
8592
List<String> hexagons = h3.gridDisk("821c07fffffffff", 1);

0 commit comments

Comments
 (0)