Skip to content

Commit a8d8b99

Browse files
committed
changes
1 parent 53c78b6 commit a8d8b99

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/test-info/test-info.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ export class BuildTargetTestCaseInfo extends TestCaseInfo {
124124
}
125125
}
126126

127-
// Add the IDE tag (--define flag) to additionalBazelParams
127+
// Additional Bazel params is not supported in BSP coverage for now
128128
const ideTag = currentRun.getIdeTag()
129-
if (ideTag && ideTag.trim().length > 0) {
129+
if (ideTag && !bazelParams.coverage) {
130130
if (bazelParams.additionalBazelParams) {
131131
bazelParams.additionalBazelParams += ` ${ideTag}`
132132
} else {

src/test/suite/run-factory.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ suite('Test Runner Factory', () => {
134134
sampleToken
135135
)
136136
assert.ok(detectIdeClientStub.calledOnce)
137-
assert.equal(runTracker.getIdeTag(), '--define=ide_client=test-ide')
137+
assert.equal(runTracker.getIdeTag(), '--test_env=IDE_CLIENT=test-ide')
138138
} finally {
139139
detectIdeClientStub.restore()
140140
}

src/test/suite/runner.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ suite('Test Runner', () => {
238238
assert.ok(!callArgs[1].data.coverage)
239239
assert.strictEqual(
240240
callArgs[1].data.additionalBazelParams,
241-
'--my_flag_1 --my_flag_2 --define=ide_client=cursor'
241+
'--my_flag_1 --my_flag_2 --test_env=IDE_CLIENT=cursor'
242242
)
243243
assert.strictEqual(callArgs[1].dataKind, TestParamsDataKind.BazelTest)
244244
}

src/test/suite/test-info.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ suite('TestInfo', () => {
207207
const currentRun = sandbox.createStubInstance(TestRunTracker)
208208
sandbox.stub(currentRun, 'originName').get(() => 'sample')
209209
currentRun.getRunProfileKind.returns(vscode.TestRunProfileKind.Run)
210-
currentRun.getIdeTag.returns('--define=ide_client=cursor')
210+
currentRun.getIdeTag.returns('--test_env=IDE_CLIENT=cursor')
211211

212212
const result = testInfo.prepareTestRunParams(currentRun)
213213
assert.deepStrictEqual(result, {
@@ -223,7 +223,7 @@ suite('TestInfo', () => {
223223
dataKind: TestParamsDataKind.BazelTest,
224224
data: {
225225
coverage: false,
226-
additionalBazelParams: '--define=ide_client=cursor',
226+
additionalBazelParams: '--test_env=IDE_CLIENT=cursor',
227227
},
228228
})
229229
})

0 commit comments

Comments
 (0)