clang-tidy fixes

Author: rhaschke

core/include/moveit/task_constructor/solvers/cartesian_path.h

@@ -60,7 +60,7 @@ class CartesianPath : public PlannerInterface
 	void setStepSize(double step_size) { setProperty("step_size", step_size); }
 	void setPrecision(const moveit::core::CartesianPrecision& precision) { setProperty("precision", precision); }
 	template <typename T = float>
-	void setJumpThreshold(double) {
+	void setJumpThreshold(double /*unused*/) {
 		static_assert(std::is_integral<T>::value, "setJumpThreshold() is deprecated. Replace with setPrecision.");
 	}
 	void setMinFraction(double min_fraction) { setProperty("min_fraction", min_fraction); }

core/include/moveit/task_constructor/stages/generate_random_pose.h

@@ -56,7 +56,7 @@ class GenerateRandomPose : public GeneratePose
 
 	/** Function signature for pose dimension samplers.
 	 * The input parameter is the seed, the returned value is the sampling result. */
-	typedef std::function<double(double)> PoseDimensionSampler;
+	using PoseDimensionSampler = std::function<double(double)>;
 	enum PoseDimension
 	{
 		X,

core/python/bindings/src/properties.cpp

@@ -59,7 +59,7 @@ class PropertyConverterRegistry
 		PropertyConverterBase::from_python_converter_function from_;
 	};
 	// map from type_index to corresponding converter functions
-	typedef std::map<std::type_index, Entry> RegistryMap;
+	using RegistryMap = std::map<std::type_index, Entry>;
 	RegistryMap types_;
 	// map from ros-msg-names to entry in types_
 	using RosMsgTypeNameMap = std::map<std::string, RegistryMap::iterator>;

core/test/stage_mockups.h

@@ -65,7 +65,7 @@ struct GeneratorMockup : public Generator
 	void init(const moveit::core::RobotModelConstPtr& robot_model) override;
 	bool canCompute() const override;
 	void compute() override;
-	virtual void reset() override { runs_ = 0; };
+	void reset() override { runs_ = 0; };
 };
 
 struct MonitoringGeneratorMockup : public MonitoringGenerator
@@ -82,7 +82,7 @@ struct MonitoringGeneratorMockup : public MonitoringGenerator
 	bool canCompute() const override { return false; }
 	void compute() override {}
 	void onNewSolution(const SolutionBase& s) override;
-	virtual void reset() override { runs_ = 0; };
+	void reset() override { runs_ = 0; };
 };
 
 struct ConnectMockup : public Connecting
@@ -99,7 +99,7 @@ struct ConnectMockup : public Connecting
 	using Connecting::compatible;  // make this accessible for testing
 
 	void compute(const InterfaceState& from, const InterfaceState& to) override;
-	virtual void reset() override { runs_ = 0; };
+	void reset() override { runs_ = 0; };
 };
 
 struct PropagatorMockup : public PropagatingEitherWay
@@ -116,7 +116,7 @@ struct PropagatorMockup : public PropagatingEitherWay
 
 	void computeForward(const InterfaceState& from) override;
 	void computeBackward(const InterfaceState& to) override;
-	virtual void reset() override { runs_ = 0; };
+	void reset() override { runs_ = 0; };
 };
 
 struct ForwardMockup : public PropagatorMockup