clang-tidy fixes: std::endl -> '\n'

Author: rhaschke

core/src/container.cpp

@@ -62,24 +62,24 @@ printChildrenInterfaces(const ContainerBasePrivate& container, bool success, con
                         std::ostream& os = std::cerr) {
 	static unsigned int id = 0;
 	const unsigned int width = 10;  // indentation of name
-	os << std::endl << (success ? '+' : '-') << ' ' << creator.name() << ' ';
+	os << '\n' << (success ? '+' : '-') << ' ' << creator.name() << ' ';
 	if (success)
 		os << ++id << ' ';
 	if (const auto conn = dynamic_cast<const ConnectingPrivate*>(creator.pimpl()))
 		os << conn->pendingPairsPrinter();
-	os << std::endl;
+	os << '\n';
 
 	for (const auto& child : container.children()) {
 		auto cimpl = child->pimpl();
 		os << std::setw(width) << std::left << child->name();
 		if (!cimpl->starts() && !cimpl->ends())
-			os << "↕ " << std::endl;
+			os << "↕ \n";
 		if (cimpl->starts())
-			os << "↓ " << *child->pimpl()->starts() << std::endl;
+			os << "↓ " << *child->pimpl()->starts() << '\n';
 		if (cimpl->starts() && cimpl->ends())
 			os << std::setw(width) << "  ";
 		if (cimpl->ends())
-			os << "↑ " << *child->pimpl()->ends() << std::endl;
+			os << "↑ " << *child->pimpl()->ends() << '\n';
 	}
 }
 
@@ -459,7 +459,7 @@ void ContainerBase::explainFailure(std::ostream& os) const {
 		if (stage->numFailures()) {
 			os << stage->name() << " (0/" << stage->numFailures() << ")";
 			stage->explainFailure(os);
-			os << std::endl;
+			os << '\n';
 			break;
 		}
 		stage->explainFailure(os);  // recursively process children
@@ -468,7 +468,7 @@ void ContainerBase::explainFailure(std::ostream& os) const {
 
 std::ostream& operator<<(std::ostream& os, const ContainerBase& container) {
 	ContainerBase::StageCallback processor = [&os](const Stage& stage, unsigned int depth) -> bool {
-		os << std::string(2 * depth, ' ') << *stage.pimpl() << std::endl;
+		os << std::string(2 * depth, ' ') << *stage.pimpl() << '\n';
 		return true;
 	};
 	container.traverseRecursively(processor);

core/src/introspection.cpp

@@ -171,7 +171,7 @@ void Introspection::publishAllSolutions(bool wait) {
 		publishSolution(*solution);
 
 		if (wait) {
-			std::cout << "Press <Enter> to continue ..." << std::endl;
+			std::cout << "Press <Enter> to continue ...\n";
 			int ch = getchar();
 			if (ch == 'q' || ch == 'Q')
 				break;

core/src/stage.cpp

@@ -90,9 +90,9 @@ const char* InitStageException::what() const noexcept {
 }
 
 std::ostream& operator<<(std::ostream& os, const InitStageException& e) {
-	os << "Error initializing stage" << (e.errors_.size() > 1 ? "s" : "") << ":" << std::endl;
+	os << "Error initializing stage" << (e.errors_.size() > 1 ? "s" : "") << ":\n ";
 	for (const auto& pair : e.errors_)
-		os << pair.first->name() << ": " << pair.second << std::endl;
+		os << pair.first->name() << ": " << pair.second << '\n';
 	return os;
 }
 
@@ -840,10 +840,10 @@ void ConnectingPrivate::newState(Interface::iterator it, Interface::UpdateFlags
 			os << (updated ? " !" : " +");
 		else
 			os << "  ";
-		os << d << " " << this->pullInterface(d) << ": " << *this->pullInterface(d) << std::endl;
+		os << d << " " << this->pullInterface(d) << ": " << *this->pullInterface(d) << '\n';
 	}
 	os << std::setw(15) << " ";
-	os << pendingPairsPrinter() << std::endl;
+	os << pendingPairsPrinter() << '\n';
 #endif
 }
 

core/test/pick_pa10.cpp

@@ -179,7 +179,7 @@ TEST(PA10, pick) {
 	try {
 		t.plan();
 	} catch (const InitStageException& e) {
-		ADD_FAILURE() << "planning failed with exception" << std::endl << e << t;
+		ADD_FAILURE() << "planning failed with exception\n" << e << t;
 	}
 
 	auto solutions = t.solutions().size();

core/test/pick_pr2.cpp

@@ -77,7 +77,7 @@ TEST(PR2, pick) {
 		spawnObject();
 		t.plan();
 	} catch (const InitStageException& e) {
-		ADD_FAILURE() << "planning failed with exception" << std::endl << e << t;
+		ADD_FAILURE() << "planning failed with exception\n" << e << t;
 	}
 
 	auto solutions = t.solutions().size();

core/test/pick_ur5.cpp

@@ -79,7 +79,7 @@ TEST(UR5, pick) {
 		spawnObject();
 		t.plan();
 	} catch (const InitStageException& e) {
-		ADD_FAILURE() << "planning failed with exception" << std::endl << e << t;
+		ADD_FAILURE() << "planning failed with exception\n" << e << t;
 	}
 
 	auto solutions = t.solutions().size();

core/test/test_container.cpp

@@ -625,7 +625,7 @@ TEST(Task, reuse) {
 		configure(t);
 		EXPECT_TRUE(t.plan(1));
 	} catch (const InitStageException& e) {
-		ADD_FAILURE() << "InitStageException:" << std::endl << e << t;
+		ADD_FAILURE() << "InitStageException:\n" << e << t;
 	}
 }
 

core/test/test_cost_queue.cpp

@@ -126,7 +126,7 @@ TYPED_TEST(OrderedTest, sorting) {
 template <typename ValueType, typename CostType>
 std::ostream& operator<<(std::ostream& os, const cost_ordered<ValueType, CostType>& queue) {
 	for (const auto& pair : queue.sorted())
-		os << pair.cost() << ": " << pair.value() << std::endl;
+		os << pair.cost() << ": " << pair.value() << '\n';
 	return os;
 }
 

core/test/test_move_to.cpp

@@ -201,7 +201,7 @@ TEST(Task, taskMoveConstructor) {
 		t.init();
 		EXPECT_TRUE(t.plan(1));
 	} catch (const InitStageException& e) {
-		ADD_FAILURE() << "InitStageException:" << std::endl << e << t;
+		ADD_FAILURE() << "InitStageException:\n" << e << t;
 	}
 }
 

demo/src/alternative_path_costs.cpp

@@ -73,7 +73,7 @@ int main(int argc, char** argv) {
 	try {
 		t.plan(0);
 	} catch (const InitStageException& e) {
-		std::cout << e << std::endl;
+		std::cout << e << '\n';
 	}
 
 	ros::spin();