Rely on CXXFLAGS definition from moveit_common package

Author: rhaschke

.github/workflows/ci.yaml

@@ -20,15 +20,11 @@ jobs:
       matrix:
         env:
           - IMAGE: humble-source
-            CXXFLAGS: >-
-             -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith
           - IMAGE: rolling-source
             NAME: ccov
             TARGET_CMAKE_ARGS: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="--coverage"
           - IMAGE: rolling-source
             CLANG_TIDY: pedantic
-            CXXFLAGS: >-
-             -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith
           - IMAGE: rolling-source
             NAME: asan
             # Add fast_unwind_on_malloc=0 to fix stacktraces being too short or do not make sense
@@ -46,6 +42,7 @@ jobs:
       UNDERLAY: /root/ws_moveit/install
       # TODO: Port to ROS2
       # DOWNSTREAM_WORKSPACE: "github:ubi-agni/mtc_demos#master github:TAMS-Group/mtc_pour#master"
+      TARGET_CMAKE_ARGS: -DCMAKE_BUILD_TYPE=Release
       CCACHE_DIR: ${{ github.workspace }}/.ccache
       BASEDIR: ${{ github.workspace }}/.work
       CACHE_PREFIX: "${{ matrix.env.IMAGE }}${{ contains(matrix.env.TARGET_CMAKE_ARGS, '--coverage') && '-ccov' || '' }}"

capabilities/CMakeLists.txt

@@ -1,11 +1,11 @@
 cmake_minimum_required(VERSION 3.5)
 project(moveit_task_constructor_capabilities)
 
-add_compile_options(-std=c++17)
-
 find_package(ament_cmake REQUIRED)
 
 find_package(Boost REQUIRED)
+find_package(moveit_common REQUIRED)
+moveit_package()
 find_package(moveit_core REQUIRED)
 find_package(moveit_ros_move_group REQUIRED)
 find_package(moveit_task_constructor_msgs REQUIRED)

core/CMakeLists.txt

@@ -5,6 +5,8 @@ find_package(ament_cmake REQUIRED)
 
 find_package(Boost REQUIRED)
 find_package(geometry_msgs REQUIRED)
+find_package(moveit_common REQUIRED)
+moveit_package()
 find_package(moveit_core REQUIRED)
 find_package(moveit_ros_planning REQUIRED)
 find_package(moveit_ros_planning_interface REQUIRED)

demo/CMakeLists.txt

@@ -8,6 +8,8 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 find_package(ament_cmake REQUIRED)
 
 find_package(generate_parameter_library REQUIRED)
+find_package(moveit_common REQUIRED)
+moveit_package()
 find_package(moveit_core REQUIRED)
 find_package(moveit_ros_planning REQUIRED)
 find_package(moveit_ros_planning_interface REQUIRED)

rviz_marker_tools/CMakeLists.txt

@@ -2,6 +2,8 @@ cmake_minimum_required(VERSION 3.5)
 project(rviz_marker_tools)
 
 find_package(ament_cmake REQUIRED)
+find_package(moveit_common REQUIRED)
+moveit_package()
 
 set(THIS_PACKAGE_INCLUDE_DEPENDS
 	eigen3_cmake_module

visualization/CMakeLists.txt

@@ -3,6 +3,8 @@ project(moveit_task_constructor_visualization)
 
 find_package(ament_cmake REQUIRED)
 find_package(Boost REQUIRED)
+find_package(moveit_common REQUIRED)
+moveit_package()
 find_package(moveit_core REQUIRED)
 find_package(moveit_ros_visualization REQUIRED)
 find_package(moveit_task_constructor_core REQUIRED)