Make it possible to create discusion for a specific change (#647)

* Make it possible to create discusion for a specific change

* Update PublicAPI.Unshipped.txt

* Update MergeRequestDiscussionCreate.cs and PublicAPI.Unshipped.txt

Author: Codex04

NGitLab.Mock/Clients/MergeRequestCommentClient.cs

@@ -71,6 +71,27 @@ public Models.MergeRequestComment Add(MergeRequestCommentCreate commentCreate)
         }
     }
 
+    public Models.MergeRequestComment Add(string discussionId, MergeRequestCommentCreate commentCreate)
+    {
+        EnsureUserIsAuthenticated();
+
+        using (Context.BeginOperationScope())
+        {
+            var project = GetProject(_projectId, ProjectPermission.View);
+            if (project.Archived)
+                throw new GitLabForbiddenException();
+
+            var comment = new MergeRequestComment
+            {
+                Author = Context.User,
+                Body = commentCreate.Body,
+            };
+
+            GetMergeRequest().Comments.Add(comment);
+            return comment.ToMergeRequestCommentClient();
+        }
+    }
+
     public Models.MergeRequestComment Edit(long id, MergeRequestCommentEdit edit)
     {
         using (Context.BeginOperationScope())

NGitLab/IMergeRequestCommentClient.cs

@@ -15,6 +15,8 @@ public interface IMergeRequestCommentClient
 
     MergeRequestComment Add(MergeRequestCommentCreate comment);
 
+    MergeRequestComment Add(string discussionId, MergeRequestCommentCreate comment);
+
     MergeRequestComment Edit(long id, MergeRequestCommentEdit comment);
 
     void Delete(long id);

NGitLab/Impl/MergeRequestCommentClient.cs

@@ -25,6 +25,8 @@ public MergeRequestCommentClient(API api, string projectPath, int mergeRequestIi
 
     public MergeRequestComment Add(MergeRequestCommentCreate comment) => _api.Post().With(comment).To<MergeRequestComment>(_notesPath);
 
+    public MergeRequestComment Add(string discussionId, MergeRequestCommentCreate comment) => _api.Post().With(comment).To<MergeRequestComment>(_discussionsPath + "/" + discussionId + "/notes");
+
     public MergeRequestComment Edit(long id, MergeRequestCommentEdit comment) => _api.Put().With(comment).To<MergeRequestComment>(_notesPath + "/" + id.ToString(CultureInfo.InvariantCulture));
 
     public void Delete(long id) => _api.Delete().Execute(_notesPath + "/" + id.ToString(CultureInfo.InvariantCulture));

NGitLab/Models/MergeRequestDiscussionCreate.cs

@@ -10,4 +10,7 @@ public class MergeRequestDiscussionCreate
 
     [JsonPropertyName("created_at")]
     public DateTime? CreatedAt;
+
+    [JsonPropertyName("position")]
+    public Position Position { get; set; }
 }

NGitLab/Models/Position.cs

@@ -21,4 +21,13 @@ public class Position
 
     [JsonPropertyName("line_range")]
     public LineRange LineRange { get; set; }
+
+    [JsonPropertyName("base_sha")]
+    public Sha1 BaseSha { get; set; }
+
+    [JsonPropertyName("head_sha")]
+    public Sha1 HeadSha { get; set; }
+
+    [JsonPropertyName("start_sha")]
+    public Sha1 StartSha { get; set; }
 }

NGitLab/Models/PositionType.cs

@@ -1,7 +1,11 @@
+using System.Runtime.Serialization;
+
 namespace NGitLab.Models;
 
 public enum PositionType
 {
+    [EnumMember(Value = "text")]
     Text,
+    [EnumMember(Value = "image")]
     Image,
 }

NGitLab/PublicAPI.Unshipped.txt

@@ -414,6 +414,7 @@ NGitLab.IMergeRequestClient.Update(int mergeRequestIid, NGitLab.Models.MergeRequ
 NGitLab.IMergeRequestCommentClient
 NGitLab.IMergeRequestCommentClient.Add(NGitLab.Models.MergeRequestComment comment) -> NGitLab.Models.MergeRequestComment
 NGitLab.IMergeRequestCommentClient.Add(NGitLab.Models.MergeRequestCommentCreate comment) -> NGitLab.Models.MergeRequestComment
+NGitLab.IMergeRequestCommentClient.Add(string discussionId, NGitLab.Models.MergeRequestCommentCreate comment) -> NGitLab.Models.MergeRequestComment
 NGitLab.IMergeRequestCommentClient.All.get -> System.Collections.Generic.IEnumerable<NGitLab.Models.MergeRequestComment>
 NGitLab.IMergeRequestCommentClient.Delete(long id) -> void
 NGitLab.IMergeRequestCommentClient.Discussions.get -> System.Collections.Generic.IEnumerable<NGitLab.Models.MergeRequestDiscussion>
@@ -688,6 +689,7 @@ NGitLab.Impl.MergeRequestClient.Update(int mergeRequestIid, NGitLab.Models.Merge
 NGitLab.Impl.MergeRequestCommentClient
 NGitLab.Impl.MergeRequestCommentClient.Add(NGitLab.Models.MergeRequestComment comment) -> NGitLab.Models.MergeRequestComment
 NGitLab.Impl.MergeRequestCommentClient.Add(NGitLab.Models.MergeRequestCommentCreate comment) -> NGitLab.Models.MergeRequestComment
+NGitLab.Impl.MergeRequestCommentClient.Add(string discussionId, NGitLab.Models.MergeRequestCommentCreate comment) -> NGitLab.Models.MergeRequestComment
 NGitLab.Impl.MergeRequestCommentClient.All.get -> System.Collections.Generic.IEnumerable<NGitLab.Models.MergeRequestComment>
 NGitLab.Impl.MergeRequestCommentClient.Delete(long id) -> void
 NGitLab.Impl.MergeRequestCommentClient.Discussions.get -> System.Collections.Generic.IEnumerable<NGitLab.Models.MergeRequestDiscussion>
@@ -2376,6 +2378,8 @@ NGitLab.Models.MergeRequestDiscussionCreate
 NGitLab.Models.MergeRequestDiscussionCreate.Body -> string
 NGitLab.Models.MergeRequestDiscussionCreate.CreatedAt -> System.DateTime?
 NGitLab.Models.MergeRequestDiscussionCreate.MergeRequestDiscussionCreate() -> void
+NGitLab.Models.MergeRequestDiscussionCreate.Position.get -> NGitLab.Models.Position
+NGitLab.Models.MergeRequestDiscussionCreate.Position.set -> void
 NGitLab.Models.MergeRequestDiscussionResolve
 NGitLab.Models.MergeRequestDiscussionResolve.Id -> string
 NGitLab.Models.MergeRequestDiscussionResolve.MergeRequestDiscussionResolve() -> void
@@ -2698,6 +2702,10 @@ NGitLab.Models.PipelineVariable.PipelineVariable() -> void
 NGitLab.Models.PipelineVariable.Value -> string
 NGitLab.Models.PipelineVariable.VariableType -> string
 NGitLab.Models.Position
+NGitLab.Models.Position.BaseSha.get -> NGitLab.Sha1
+NGitLab.Models.Position.BaseSha.set -> void
+NGitLab.Models.Position.HeadSha.get -> NGitLab.Sha1
+NGitLab.Models.Position.HeadSha.set -> void
 NGitLab.Models.Position.LineRange.get -> NGitLab.Models.LineRange
 NGitLab.Models.Position.LineRange.set -> void
 NGitLab.Models.Position.NewLine.get -> int?
@@ -2711,6 +2719,8 @@ NGitLab.Models.Position.OldPath.set -> void
 NGitLab.Models.Position.Position() -> void
 NGitLab.Models.Position.PositionType.get -> NGitLab.DynamicEnum<NGitLab.Models.PositionType>
 NGitLab.Models.Position.PositionType.set -> void
+NGitLab.Models.Position.StartSha.get -> NGitLab.Sha1
+NGitLab.Models.Position.StartSha.set -> void
 NGitLab.Models.PositionType
 NGitLab.Models.PositionType.Image = 1 -> NGitLab.Models.PositionType
 NGitLab.Models.PositionType.Text = 0 -> NGitLab.Models.PositionType