Skip to content

Commit 34e87a4

Browse files
louis-zToa741
andauthored
Properly await tasks before disposing of resources (#771)
Properly await tasks before disposing of resources in repository mock tests Co-authored-by: Thomas Cortes <78750681+Toa741@users.noreply.github.com>
1 parent 29e0bc9 commit 34e87a4

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

NGitLab.Mock.Tests/RepositoryMockTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using System.Collections.Generic;
2-
using System.Net;
32
using FluentAssertions;
43
using NGitLab.Mock.Clients;
54
using NGitLab.Models;

NGitLab.Mock.Tests/UsingVerify/RepositoryMockTests.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void Test_get_tree_when_subdirectory_does_not_exist_throws_not_found()
3333
}
3434

3535
[Test]
36-
public Task Test_get_tree_item_has_id_and_mode()
36+
public async Task Test_get_tree_item_has_id_and_mode()
3737
{
3838
// Arrange
3939
using var server = new GitLabConfig()
@@ -50,11 +50,11 @@ public Task Test_get_tree_item_has_id_and_mode()
5050
var tree = repository.GetTreeAsync(new RepositoryGetTreeOptions());
5151

5252
// Assert
53-
return Verify(tree);
53+
await Verify(tree);
5454
}
5555

5656
[Test]
57-
public Task Test_get_tree_item_in_sub_folder()
57+
public async Task Test_get_tree_item_in_sub_folder()
5858
{
5959
// Arrange
6060
using var server = new GitLabConfig()
@@ -72,11 +72,11 @@ public Task Test_get_tree_item_in_sub_folder()
7272
var tree = repository.GetTreeAsync(new RepositoryGetTreeOptions { Path = "subFolder" });
7373

7474
// Assert
75-
return Verify(tree);
75+
await Verify(tree);
7676
}
7777

7878
[Test]
79-
public Task Test_get_tree_with_recurse()
79+
public async Task Test_get_tree_with_recurse()
8080
{
8181
// Arrange
8282
using var server = new GitLabConfig()
@@ -94,11 +94,11 @@ public Task Test_get_tree_with_recurse()
9494
var tree = repository.GetTreeAsync(new RepositoryGetTreeOptions { Recursive = true });
9595

9696
// Assert
97-
return Verify(tree);
97+
await Verify(tree);
9898
}
9999

100100
[Test]
101-
public Task Test_get_tree_not_in_main_branch()
101+
public async Task Test_get_tree_not_in_main_branch()
102102
{
103103
// Arrange
104104
using var server = new GitLabConfig()
@@ -117,11 +117,11 @@ public Task Test_get_tree_not_in_main_branch()
117117
var tree = repository.GetTreeAsync(new RepositoryGetTreeOptions { Ref = "feature", Recursive = true });
118118

119119
// Assert
120-
return Verify(tree);
120+
await Verify(tree);
121121
}
122122

123123
[Test]
124-
public Task Test_get_raw_blob_content()
124+
public async Task Test_get_raw_blob_content()
125125
{
126126
// Arrange
127127
using var server = new GitLabConfig()
@@ -143,6 +143,6 @@ public Task Test_get_raw_blob_content()
143143
repository.GetRawBlob(item.Id.ToString(), source => source.CopyTo(destination));
144144

145145
// Assert
146-
return Verify(destination);
146+
await Verify(destination);
147147
}
148148
}

0 commit comments

Comments
 (0)