Convert public fields to properties (#814)

* Convert public fields to properties

* Run dotnet format

* Don't include fields in JSON serialization anymore

* Make Runner.Online a nullable bool

* Delete script

Author: louis-z

NGitLab.Mock.Tests/GroupsMockTests.cs

@@ -349,7 +349,7 @@ public void Test_create_update_delete_group_hooks()
         var groupId = 1;
 
         using var server = new GitLabConfig()
-            .WithUser("user1",  isAdmin: true)
+            .WithUser("user1", isAdmin: true)
             .WithGroup("group1", groupId)
             .BuildServer();
 

NGitLab.Mock.Tests/UsingVerify/RepositoryMockTests.cs

@@ -4,9 +4,9 @@
 using NGitLab.Mock.Clients;
 using NGitLab.Mock.Config;
 using NUnit.Framework;
+using static VerifyNUnit.Verifier;
 using RepositoryGetTreeOptions = NGitLab.Models.RepositoryGetTreeOptions;
 using Throws = NUnit.Framework.Throws;
-using static VerifyNUnit.Verifier;
 
 namespace NGitLab.Mock.Tests.UsingVerify;
 

NGitLab.Mock/Change.cs

@@ -20,7 +20,7 @@ public class Change : GitLabObject
 
     public Models.Change ToChange()
     {
-        return new ()
+        return new()
         {
             Diff = Diff,
             AMode = AMode,

NGitLab.Mock/Clients/MergeRequestChangeClient.cs

@@ -3,7 +3,7 @@
 
 namespace NGitLab.Mock.Clients;
 
-internal sealed class  MergeRequestChangeClient : ClientBase, IMergeRequestChangeClient
+internal sealed class MergeRequestChangeClient : ClientBase, IMergeRequestChangeClient
 {
     private readonly long _projectId;
     private readonly long _mergeRequestIid;

NGitLab.Mock/PipelineSchedule.cs

@@ -46,7 +46,7 @@ public PipelineScheduleBasic ToPipelineScheduleBasicClient()
     public Models.PipelineSchedule ToPipelineScheduleClient()
         => new()
         {
-            Id  = Id,
+            Id = Id,
             Active = Active,
             CreatedAt = CreatedAt,
             Cron = Cron,

NGitLab.Tests/AsyncApiValidation.cs

@@ -34,7 +34,7 @@ public void ValidateAsyncMethodSignature()
 
                     if (parameterInfo.ParameterType != typeof(CancellationToken))
                     {
-                       Assert.Fail($"The last parameter of method '{method}' must be of type 'CancellationToken' and named 'cancellationToken'");
+                        Assert.Fail($"The last parameter of method '{method}' must be of type 'CancellationToken' and named 'cancellationToken'");
                     }
 
                     if (!string.Equals(parameterInfo.Name, "cancellationToken", StringComparison.Ordinal))

NGitLab.Tests/PipelineTests.cs

@@ -89,7 +89,8 @@ public async Task Test_can_list_jobs_from_pipeline()
 
         var pipelineJobQuery = new PipelineJobQuery
         {
-            PipelineId = pipeline.Id, Scope = new[] { "success", "pending" },
+            PipelineId = pipeline.Id,
+            Scope = new[] { "success", "pending" },
         };
         var allJobs = await GitLabTestContext.RetryUntilAsync(() => pipelineClient.GetJobsAsync(pipelineJobQuery).ToList(), p => p.Count != 0, TimeSpan.FromSeconds(120));
         Assert.That(allJobs.Count != 0);

NGitLab.Tests/RunnerTests.cs

@@ -132,6 +132,6 @@ private static RetryPolicy GetRetryPolicy()
     {
         return Policy
             .Handle<GitLabException>(ex => ex.StatusCode is HttpStatusCode.Forbidden)
-            .WaitAndRetry(3, sleepDurationProvider: attempt => TimeSpan.FromSeconds(2 * attempt));    
+            .WaitAndRetry(3, sleepDurationProvider: attempt => TimeSpan.FromSeconds(2 * attempt));
     }
 }

NGitLab/Impl/Json/Serializer.cs

@@ -8,7 +8,6 @@ internal static class Serializer
 {
     private static readonly JsonSerializerOptions _options = new()
     {
-        IncludeFields = true,
         Converters =
         {
             new BooleanConverter(),

NGitLab/Models/AccessControl.cs

@@ -1,4 +1,4 @@
-using System.Text.Json.Serialization;
+using System.Text.Json.Serialization;
 
 namespace NGitLab.Models;