Remove before/afterChange in favor of the controller

Author: jpnurmi

lib/src/base_spin_box.dart

@@ -39,9 +39,6 @@ abstract class BaseSpinBox extends StatefulWidget {
   int get decimals;
   int get digits;
   ValueChanged<double>? get onChanged;
-  bool Function(double value)? get canChange;
-  VoidCallback? get beforeChange;
-  VoidCallback? get afterChange;
   bool get readOnly;
   FocusNode? get focusNode;
   SpinController? get controller;
@@ -80,9 +77,6 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
           value: widget.value,
           decimals: widget.decimals,
           digits: widget.digits,
-          canChange: widget.canChange,
-          beforeChange: widget.beforeChange,
-          afterChange: widget.afterChange,
         );
     _controller.addListener(_handleValueChange);
     _editor = TextEditingController(text: _controller.format(widget.value));

lib/src/cupertino/spin_box.dart

@@ -81,9 +81,6 @@ class CupertinoSpinBox extends BaseSpinBox {
     this.enableInteractiveSelection = true,
     this.spacing = 8,
     this.onChanged,
-    this.canChange,
-    this.beforeChange,
-    this.afterChange,
     this.focusNode,
     this.controller,
   })  : assert(min <= max),
@@ -209,15 +206,6 @@ class CupertinoSpinBox extends BaseSpinBox {
   @override
   final ValueChanged<double>? onChanged;
 
-  @override
-  final bool Function(double value)? canChange;
-
-  @override
-  final VoidCallback? beforeChange;
-
-  @override
-  final VoidCallback? afterChange;
-
   /// See [CupertinoTextField.enabled].
   final bool enabled;
 

lib/src/material/spin_box.dart

@@ -82,9 +82,6 @@ class SpinBox extends BaseSpinBox {
     this.enableInteractiveSelection = true,
     this.spacing = 8,
     this.onChanged,
-    this.canChange,
-    this.beforeChange,
-    this.afterChange,
     this.focusNode,
     this.controller,
   })  : assert(min <= max),
@@ -207,15 +204,6 @@ class SpinBox extends BaseSpinBox {
   @override
   final ValueChanged<double>? onChanged;
 
-  @override
-  final bool Function(double value)? canChange;
-
-  @override
-  final VoidCallback? beforeChange;
-
-  @override
-  final VoidCallback? afterChange;
-
   /// See [TextField.enabled].
   final bool enabled;
 

lib/src/spin_controller.dart

@@ -31,9 +31,6 @@ class SpinController extends ValueNotifier<double> {
     this.pageStep,
     this.decimals = 0,
     this.digits = 0,
-    this.canChange,
-    this.beforeChange,
-    this.afterChange,
   })  : _min = min,
         _max = max,
         super(value);
@@ -45,9 +42,6 @@ class SpinController extends ValueNotifier<double> {
   final double? pageStep;
   final int decimals;
   final int digits;
-  final bool Function(double value)? canChange;
-  final VoidCallback? beforeChange;
-  final VoidCallback? afterChange;
 
   double get min => _min;
   set min(double min) {
@@ -84,16 +78,14 @@ class SpinController extends ValueNotifier<double> {
   void pageStepDown() => _doStep(-(pageStep ?? 0));
   void _doStep(double step) => value += step;
 
+  bool canChange(double value) => true;
+
   @override
   set value(double v) {
     final newValue = v.clamp(min, max);
-    if (newValue == value) return;
-
-    if (canChange?.call(newValue) == false) return;
-
-    beforeChange?.call();
-    super.value = newValue;
-    afterChange?.call();
+    if (newValue != value && canChange(newValue)) {
+      super.value = newValue;
+    }
   }
 
   bool validate(String text) {