Get rid of SpinCallback

Author: jpnurmi

lib/src/base_spin_box.dart

@@ -117,17 +117,15 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
     widget.onChanged?.call(v);
   }
 
-  bool setValue(double v) {
+  void setValue(double v) {
     final newValue = v.clamp(widget.min, widget.max);
-    if (newValue == value) return false;
+    if (newValue == value) return;
 
-    if (widget.canChange?.call(newValue) == false) return false;
+    if (widget.canChange?.call(newValue) == false) return;
 
     widget.beforeChange?.call();
     setState(() => _updateController(value, newValue));
     widget.afterChange?.call();
-
-    return true;
   }
 
   void _updateController(double oldValue, double newValue) {

lib/src/cupertino/spin_button.dart

@@ -46,7 +46,7 @@ class CupertinoSpinButton extends StatelessWidget {
   final double step;
   final double? acceleration;
   final Duration interval;
-  final SpinCallback onStep;
+  final ValueChanged<double> onStep;
 
   @override
   Widget build(BuildContext context) {

lib/src/material/spin_button.dart

@@ -44,7 +44,7 @@ class SpinButton extends StatelessWidget {
   final double step;
   final double? acceleration;
   final Duration interval;
-  final SpinCallback onStep;
+  final ValueChanged<double> onStep;
 
   @override
   Widget build(BuildContext context) {

lib/src/spin_gesture.dart

@@ -26,8 +26,6 @@ import 'package:flutter/material.dart';
 
 // ignore_for_file: public_member_api_docs
 
-typedef SpinCallback = bool Function(double value);
-
 class SpinGesture extends StatefulWidget {
   const SpinGesture({
     Key? key,
@@ -44,7 +42,7 @@ class SpinGesture extends StatefulWidget {
   final double step;
   final double? acceleration;
   final Duration interval;
-  final SpinCallback onStep;
+  final ValueChanged<double> onStep;
 
   @override
   State<SpinGesture> createState() => _SpinGestureState();
@@ -60,6 +58,14 @@ class _SpinGestureState extends State<SpinGesture> {
     step = widget.step;
   }
 
+  @override
+  void didUpdateWidget(covariant SpinGesture oldWidget) {
+    super.didUpdateWidget(oldWidget);
+    if (oldWidget.enabled && !widget.enabled) {
+      stopTimer();
+    }
+  }
+
   @override
   void dispose() {
     stopTimer();
@@ -75,18 +81,19 @@ class _SpinGestureState extends State<SpinGesture> {
     );
   }
 
-  bool onStep() {
-    if (!widget.enabled) return false;
+  void onStep() {
+    if (!widget.enabled) return;
     if (widget.acceleration != null) {
       step += widget.acceleration!;
     }
-    return widget.onStep(step);
+    widget.onStep(step);
   }
 
   void startTimer() {
     if (timer != null) return;
     timer = Timer.periodic(widget.interval, (timer) {
-      if (!onStep()) {
+      onStep();
+      if (!widget.enabled) {
         stopTimer();
       }
     });