chore: process snapshot.hasError in future builders (#78)

Feichtmeier · web-flow · commit 2061459064c3 · 2025-07-14T16:12:15.000Z
diff --git a/lib/app/view/error_page.dart b/lib/app/view/error_page.dart
@@ -0,0 +1,32 @@
+import 'package:flutter/material.dart';
+import 'package:yaru/yaru.dart';
+import '../../l10n/l10n.dart';
+
+class ErrorPage extends StatelessWidget {
+  const ErrorPage({super.key, required this.error});
+
+  final String error;
+
+  @override
+  Widget build(BuildContext context) {
+    return Scaffold(
+      appBar: YaruWindowTitleBar(
+        title: Text(context.l10n.oopsSomethingWentWrong),
+        border: BorderSide.none,
+        backgroundColor: Colors.transparent,
+      ),
+      body: ErrorBody(error: error),
+    );
+  }
+}
+
+class ErrorBody extends StatelessWidget {
+  const ErrorBody({super.key, required this.error});
+
+  final String error;
+
+  @override
+  Widget build(BuildContext context) {
+    return Center(child: Text('An error occurred: $error'));
+  }
+}
diff --git a/lib/app/view/wait_for_registration_page.dart b/lib/app/view/wait_for_registration_page.dart
@@ -5,6 +5,7 @@ import '../../authentication/authentication_model.dart';
 import '../../authentication/view/chat_login_page.dart';
 import '../../encryption/view/check_encryption_setup_page.dart';
 import 'app.dart';
+import 'error_page.dart';
 import 'splash_page.dart';
 
 class WaitForRegistrationPage extends StatefulWidget {
@@ -38,7 +39,16 @@ class _WaitForRegistrationPageState extends State<WaitForRegistrationPage> {
   @override
   Widget build(BuildContext context) => FutureBuilder(
     future: _registrationReady,
-    builder: (context, snapshot) => snapshot.hasData
+    builder: (context, snapshot) => snapshot.hasError
+        ? App(
+            themeMode: ThemeMode.system,
+            lightTheme: widget.lightTheme,
+            darkTheme: widget.darkTheme,
+            highContrastDarkTheme: widget.highContrastDarkTheme,
+            highContrastTheme: widget.highContrastTheme,
+            child: ErrorPage(error: snapshot.error.toString()),
+          )
+        : snapshot.hasData
         ? App(
             lightTheme: widget.lightTheme,
             darkTheme: widget.darkTheme,
diff --git a/lib/chat_master/view/chat_room_master_tile_subtitle.dart b/lib/chat_master/view/chat_room_master_tile_subtitle.dart
@@ -65,6 +65,9 @@ class ChatRoomLastEvent extends StatelessWidget {
         withSenderNamePrefix: true,
       ),
       builder: (context, snapshot) {
+        if (snapshot.hasError) {
+          return const Text('?', maxLines: 1);
+        }
         if (snapshot.hasData && lastEvent != null) {
           return Text(snapshot.data!, maxLines: 1);
         }
diff --git a/lib/chat_room/common/view/chat_room_page.dart b/lib/chat_room/common/view/chat_room_page.dart
@@ -6,6 +6,7 @@ import 'package:matrix/matrix.dart';
 import 'package:super_drag_and_drop/super_drag_and_drop.dart';
 import 'package:watch_it/watch_it.dart';
 
+import '../../../app/view/error_page.dart';
 import '../../../common/chat_model.dart';
 import '../../../common/room_x.dart';
 import '../../../common/view/build_context_x.dart';
@@ -148,6 +149,9 @@ class _ChatRoomPageState extends State<ChatRoomPage> {
                     key: ValueKey(widget.room.id),
                     future: _timelineFuture,
                     builder: (context, snapshot) {
+                      if (snapshot.hasError) {
+                        return ErrorBody(error: snapshot.error.toString());
+                      }
                       if (snapshot.hasData) {
                         return Padding(
                           padding: const EdgeInsets.only(
diff --git a/lib/common/client_x.dart b/lib/common/client_x.dart
@@ -20,6 +20,7 @@ import 'platforms.dart';
 
 extension ClientX on Client {
   static Future<Client> registerAsync() async {
+    await vod.init(wasmPath: './assets/assets/vodozemac/');
     final client = Client(
       AppConfig.appId,
       nativeImplementations: kIsWeb
diff --git a/lib/common/view/chat_profile_dialog.dart b/lib/common/view/chat_profile_dialog.dart
@@ -3,6 +3,7 @@ import 'package:matrix/matrix.dart';
 import 'package:watch_it/watch_it.dart';
 import 'package:yaru/yaru.dart';
 
+import '../../app/view/error_page.dart';
 import '../../l10n/l10n.dart';
 import '../../settings/view/chat_settings_dialog.dart';
 import '../chat_model.dart';
@@ -49,6 +50,10 @@ class _ChatProfileState extends State<ChatProfile> {
     return FutureBuilder(
       future: _future,
       builder: (context, snapshot) {
+        if (snapshot.hasError) {
+          return ErrorBody(error: snapshot.error.toString());
+        }
+
         final myProfile =
             snapshot.hasData &&
             snapshot.data!.userId == di<ChatModel>().myUserId;
diff --git a/lib/encryption/view/check_encryption_setup_page.dart b/lib/encryption/view/check_encryption_setup_page.dart
@@ -1,6 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:watch_it/watch_it.dart';
 
+import '../../app/view/error_page.dart';
 import '../../app/view/splash_page.dart';
 import '../../chat_master/view/chat_master_detail_page.dart';
 import '../../l10n/l10n.dart';
@@ -28,10 +29,12 @@ class _CheckEncryptionSetupPageState extends State<CheckEncryptionSetupPage> {
   @override
   Widget build(BuildContext context) => FutureBuilder(
     future: _isEncryptionSetupNeeded,
-    builder: (context, snapshot) => !snapshot.hasData
-        ? SplashPage(title: Text(context.l10n.loadingPleaseWait))
-        : (snapshot.data == true
+    builder: (context, snapshot) => snapshot.hasError
+        ? ErrorPage(error: snapshot.error.toString())
+        : snapshot.hasData
+        ? (snapshot.data == true
               ? const SetupEncryptedChatPage()
-              : const ChatMasterDetailPage()),
+              : const ChatMasterDetailPage())
+        : SplashPage(title: Text(context.l10n.loadingPleaseWait)),
   );
 }
diff --git a/lib/events/view/chat_html_message_link_handler.dart b/lib/events/view/chat_html_message_link_handler.dart
@@ -4,6 +4,7 @@ import 'package:matrix/matrix_api_lite/generated/model.dart';
 import 'package:url_launcher/url_launcher.dart';
 import 'package:watch_it/watch_it.dart';
 
+import '../../app/view/error_page.dart';
 import '../../common/chat_model.dart';
 import '../../common/search_model.dart';
 import '../../common/view/chat_profile_dialog.dart';
@@ -70,6 +71,11 @@ class _ChatRoomSearchDialogState extends State<ChatRoomSearchDialog> {
     return FutureBuilder(
       future: _future,
       builder: (context, snapshot) {
+        if (snapshot.hasError) {
+          return AlertDialog(
+            content: ErrorBody(error: snapshot.error.toString()),
+          );
+        }
         return ConfirmationDialog(
           confirmEnabled: snapshot.hasData,
           onConfirm: snapshot.hasData
diff --git a/lib/events/view/chat_image.dart b/lib/events/view/chat_image.dart
@@ -139,7 +139,12 @@ class _ChatImageFutureState extends State<ChatImageFuture> {
   @override
   Widget build(BuildContext context) => FutureBuilder(
     future: _future,
-    builder: (context, snapshot) => snapshot.hasData
+    builder: (context, snapshot) => snapshot.hasError
+        ? Icon(
+            YaruIcons.image_missing,
+            size: widget.height == null ? 45 : widget.height! / 2,
+          )
+        : snapshot.hasData
         ? AnimatedOpacity(
             opacity: snapshot.hasData ? 1 : 0,
             duration: const Duration(milliseconds: 300),
diff --git a/lib/events/view/chat_message_image_full_screen_dialog.dart b/lib/events/view/chat_message_image_full_screen_dialog.dart
@@ -8,6 +8,7 @@ import 'package:photo_view/photo_view.dart';
 import 'package:watch_it/watch_it.dart';
 import 'package:yaru/yaru.dart';
 
+import '../../app/view/error_page.dart';
 import '../../common/date_time_x.dart';
 import '../../common/local_image_model.dart';
 import '../../common/view/build_context_x.dart';
@@ -160,6 +161,9 @@ class _ChatMessageImageFullScreenDialogState
                     child: FutureBuilder(
                       future: _future,
                       builder: (context, snapshot) {
+                        if (snapshot.hasError) {
+                          return ErrorBody(error: snapshot.error.toString());
+                        }
                         if (snapshot.hasData) {
                           return ClipRRect(
                             child: PhotoView(
diff --git a/lib/events/view/chat_message_reply_header.dart b/lib/events/view/chat_message_reply_header.dart
@@ -49,6 +49,9 @@ class _ChatMessageReplyHeaderState extends State<ChatMessageReplyHeader> {
     return FutureBuilder(
       future: _future,
       builder: (context, snapshot) {
+        if (snapshot.hasError) {
+          return Text(snapshot.error.toString());
+        }
         if (snapshot.hasData) {
           final replyEvent = snapshot.data;
 
diff --git a/lib/events/view/localized_display_event_text.dart b/lib/events/view/localized_display_event_text.dart
@@ -45,6 +45,14 @@ class _LocalizedDisplayEventTextState extends State<LocalizedDisplayEventText> {
       : FutureBuilder(
           future: _future,
           builder: (context, snapshot) {
+            if (snapshot.hasError) {
+              return _Content(
+                text: snapshot.error.toString(),
+                style: widget.style,
+                textAlign: widget.textAlign,
+                badge: widget.displayEvent.showAsBadge,
+              );
+            }
             if (snapshot.hasData) {
               _cache.update(
                 widget.displayEvent.eventId,
diff --git a/lib/main.dart b/lib/main.dart
@@ -1,5 +1,4 @@
 import 'package:flutter/material.dart';
-import 'package:flutter_vodozemac/flutter_vodozemac.dart' as vod;
 import 'package:system_theme/system_theme.dart';
 import 'package:yaru/yaru.dart';
 
@@ -10,8 +9,6 @@ import 'register_dependencies.dart';
 void main() async {
   await YaruWindowTitleBar.ensureInitialized();
 
-  await vod.init(wasmPath: './assets/assets/vodozemac/');
-
   if (!Platforms.isLinux) {
     await SystemTheme.accentColor.load();
   }
