chore: simplify player view state update and improve metadata observation handling (#102)

Author: Feichtmeier

lib/chat_master/view/chat_master_detail_page.dart

@@ -126,7 +126,7 @@ class _ChatMasterDetailPageState extends State<ChatMasterDetailPage> {
               )
             : const Center(child: Progress()),
       ),
-      bottomNavigationBar: const PlayerView(),
+      bottomNavigationBar: const RepaintBoundary(child: PlayerView()),
     );
   }
 }

lib/chat_master/view/chat_master_panel.dart

@@ -9,6 +9,8 @@ import '../../common/view/build_context_x.dart';
 import '../../common/view/theme.dart';
 import '../../common/view/ui_constants.dart';
 import '../../l10n/l10n.dart';
+import '../../player/player_manager.dart';
+import '../../player/view/player_full_view.dart';
 import '../../settings/view/chat_settings_dialog.dart';
 import 'chat_master_list_filter_bar.dart';
 import 'chat_master_settings_tile_avatar.dart';
@@ -58,6 +60,17 @@ class ChatMasterSidePanel extends StatelessWidget with WatchItMixin {
                     context: context,
                     builder: (context) => const ChatSettingsDialog(),
                   ),
+                  trailing: IconButton(
+                    tooltip: l10n.playMedia,
+                    onPressed: () {
+                      showDialog(
+                        context: context,
+                        builder: (context) => const PlayerFullView(),
+                      );
+                      di<PlayerManager>().updateState(fullMode: true);
+                    },
+                    icon: const Icon(YaruIcons.media_play),
+                  ),
                 ),
               ],
             ),

lib/chat_master/view/chat_rooms_list.dart

@@ -13,7 +13,7 @@ class ChatRoomsList extends StatelessWidget with WatchItMixin {
         watchStream(
           (ChatManager m) => m.syncStream.map((_) => m.filteredRooms),
           initialValue: di<ChatManager>().filteredRooms,
-          preserveState: false,
+          preserveState: true,
         ).data ??
         di<ChatManager>().filteredRooms;
     watchPropertyValue((ChatManager m) => m.filteredRoomsQuery);

lib/chat_master/view/chat_space_filter.dart

@@ -22,7 +22,7 @@ class ChatSpaceFilter extends StatelessWidget with WatchItMixin {
         watchStream(
           (ChatManager m) => m.spacesStream,
           initialValue: chatManager.spaces,
-          preserveState: false,
+          preserveState: true,
         ).data ??
         chatManager.spaces;
 

lib/chat_room/common/view/chat_room_page.dart

@@ -95,7 +95,7 @@ class _ChatRoomPageState extends State<ChatRoomPage> {
                       widget.room.isDirectChat && invitedUsers.isNotEmpty,
                 ),
             initialValue: widget.room.isUnacceptedDirectChat,
-            preserveState: false,
+            preserveState: true,
           ).data;
 
     return DropRegion(

lib/chat_room/common/view/chat_room_users_list.dart

@@ -39,7 +39,7 @@ class ChatRoomUsersList extends StatelessWidget with WatchItMixin {
         membershipFilter: membershipFilter,
       ),
       initialValue: room.getParticipants(membershipFilter),
-      preserveState: false,
+      preserveState: true,
     ).data?.sorted((a, b) => b.powerLevel.compareTo(a.powerLevel));
 
     if (users == null || users.isEmpty) {

lib/chat_room/create_or_edit/view/chat_room_history_visibility_drop_down.dart

@@ -29,7 +29,7 @@ class ChatRoomHistoryVisibilityDropDown extends StatelessWidget
                 (EditRoomService m) =>
                     m.getJoinedRoomHistoryVisibilityStream(room!),
                 initialValue: room!.historyVisibility,
-                preserveState: false,
+                preserveState: true,
               ).data ??
               room!.historyVisibility;
 
@@ -39,7 +39,7 @@ class ChatRoomHistoryVisibilityDropDown extends StatelessWidget
                 (EditRoomService m) =>
                     m.getCanChangeHistoryVisibilityStream(room!),
                 initialValue: room!.canChangeHistoryVisibility,
-                preserveState: false,
+                preserveState: true,
               ).data ??
               false;
 

lib/chat_room/create_or_edit/view/chat_room_join_rules_drop_down.dart

@@ -23,15 +23,15 @@ class ChatRoomJoinRulesDropDown extends StatelessWidget with WatchItMixin {
     final canChangeJoinRules =
         watchStream(
           (EditRoomService m) => m.getCanChangeJoinRulesStream(room),
-          preserveState: false,
+          preserveState: true,
           initialValue: room.canChangeJoinRules,
         ).data ??
         room.canChangeJoinRules;
 
     final joinRules =
         watchStream(
           (EditRoomService m) => m.getJoinedRoomJoinRulesStream(room),
-          preserveState: false,
+          preserveState: true,
           initialValue: room.joinRules,
         ).data ??
         JoinRules.private;

lib/chat_room/create_or_edit/view/chat_room_permissions.dart

@@ -24,7 +24,7 @@ class ChatRoomPermissions extends StatelessWidget with WatchItMixin {
         watchStream(
           (EditRoomService m) => m.canChangePowerLevels(room),
           initialValue: room.canChangePowerLevel,
-          preserveState: false,
+          preserveState: true,
         ).data ??
         room.canChangePowerLevel;
 

lib/chat_room/create_or_edit/view/create_or_edit_room_canonical_alias_text_field.dart

@@ -45,7 +45,7 @@ class _CreateOrEditRoomCanonicalAliasTextFieldState
           (EditRoomService m) =>
               m.getCanChangeCanonicalAliasStream(widget.room),
           initialValue: widget.room.canChangeCanonicalAlias,
-          preserveState: false,
+          preserveState: true,
         ).data ??
         false;
 
@@ -55,7 +55,7 @@ class _CreateOrEditRoomCanonicalAliasTextFieldState
           (EditRoomService m) =>
               m.getJoinedRoomCanonicalAliasStream(widget.room),
           initialValue: widget.room.canonicalAlias,
-          preserveState: false,
+          preserveState: true,
         ).data ??
         widget.room.canonicalAlias;
     final homeServer = di<AuthenticationService>().homeServerName;