Skip to content

Commit 0486cab

Browse files
authored
Avoid exposing any member at all by extracting the extension (#3)
1 parent ac5668c commit 0486cab

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

packages/sane/lib/src/exceptions.dart

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'package:ffi/ffi.dart';
2-
import 'package:meta/meta.dart';
32
import 'package:sane/src/bindings.g.dart';
43
import 'package:sane/src/dylib.dart';
54

@@ -189,14 +188,3 @@ final class SaneUnsupportedException extends SaneException {
189188
@override
190189
SANE_Status get _status => SANE_Status.STATUS_UNSUPPORTED;
191190
}
192-
193-
@internal
194-
extension SaneStatusExtension on SANE_Status {
195-
/// Throws [SaneException] if the status is not [SANE_Status.STATUS_GOOD].
196-
@pragma('vm:prefer-inline')
197-
void check() {
198-
if (this != SANE_Status.STATUS_GOOD) {
199-
throw SaneException(this);
200-
}
201-
}
202-
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import 'package:sane/src/bindings.g.dart';
2+
import 'package:sane/src/exceptions.dart';
3+
4+
extension SaneStatusExtension on SANE_Status {
5+
/// Throws [SaneException] if the status is not [SANE_Status.STATUS_GOOD].
6+
@pragma('vm:prefer-inline')
7+
void check() {
8+
if (this != SANE_Status.STATUS_GOOD) {
9+
throw SaneException(this);
10+
}
11+
}
12+
}

packages/sane/lib/src/sane.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import 'package:ffi/ffi.dart' as ffi;
66
import 'package:sane/src/bindings.g.dart';
77
import 'package:sane/src/dylib.dart';
88
import 'package:sane/src/exceptions.dart';
9+
import 'package:sane/src/extensions.dart';
910
import 'package:sane/src/structures.dart';
1011
import 'package:sane/src/type_conversion.dart';
1112
import 'package:sane/src/utils.dart';

packages/sane/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ packages:
191191
source: hosted
192192
version: "0.12.16+1"
193193
meta:
194-
dependency: "direct main"
194+
dependency: transitive
195195
description:
196196
name: meta
197197
sha256: e3641ec5d63ebf0d9b41bd43201a66e3fc79a65db5f61fc181f04cd27aab950c

packages/sane/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ environment:
1111

1212
dependencies:
1313
ffi: ^2.1.3
14-
meta: ^1.16.0
1514

1615
dev_dependencies:
1716
ffigen: ^14.0.1

0 commit comments

Comments
 (0)