Skip to content

Commit 709b348

Browse files
committed
linters: fix pending versions check
For sets, ">" is not the same as "not <=". Explicitly if the set of pending versions is a subset of the changes versions.
1 parent 15a476e commit 709b348

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ubuntu_lint/linters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def check_missing_pending_changelog_entry(context: Context):
121121
ch = changelog.Changelog(lines, allow_empty_author=True)
122122
changes_versions = set([str(v) for v in ch.get_versions()])
123123

124-
if pending_versions > changes_versions:
124+
if not pending_versions <= changes_versions:
125125
# The versions listed in the changes file is not a superset
126126
# of the pending versions according to Launchpad.
127127
missing_versions = ",".join(pending_versions - changes_versions)

0 commit comments

Comments
 (0)