Skip to content

Commit 542ccf4

Browse files
committed
fix: disable not-so-useful parts of home,concept-set,cohort-definition pages
...simplifying them and making them more 508 compliant
1 parent f7c6d12 commit 542ccf4

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

js/pages/cohort-definitions/cohort-definition-manager.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,17 @@
2525
data-bind="title: ko.i18n('cohortDefinitions.cohortDefinitionManager.closeCohortTitle', 'Close cohort definition'), click: close, css: { disabled: isProcessing() }"><i
2626
class="fa fa-times"></i></button>
2727
<!-- ko if: currentCohortDefinition().id() != null && currentCohortDefinition().id() != 0 -->
28+
<!-- Hide this not-so-useful part and make the page more 508 compliant:
2829
<button class="btn btn-primary"
2930
data-bind="title: ko.i18n('common.tags', 'Tags'), visible: canEdit() && !previewVersion(), click: () => isTagsModalShown(!isTagsModalShown()), css: { disabled: isProcessing() }"><i class="fa fa-tags"></i></button>
31+
-->
3032
<button class="btn btn-primary"
3133
data-bind="visible: !previewVersion(), title: ko.i18n('cohortDefinitions.cohortDefinitionManager.createCopyCohortTitle', 'Create a copy of this cohort definition'), click: copy, enable: canCopy() && !isProcessing()"><i
3234
class="fa fa-copy"></i></button>
35+
<!-- Hide this not-so-useful part and make the page more 508 compliant:
3336
<button class="btn btn-primary"
3437
data-bind="visible: !previewVersion(), title: ko.i18n('cohortDefinitions.cohortDefinitionManager.getLinkCohortTitle', 'Get a link to this cohort definition'), enable: !dirtyFlag().isDirty() && !isProcessing(), click: function () { $component.cohortLinkModalOpened(true) }"><i class="fa fa-link"></i></button>
38+
-->
3539

3640
<!-- ko if: (enablePermissionManagement() === true && userCanShare() === true) -->
3741
<button class="btn btn-primary"
@@ -132,10 +136,12 @@
132136
<a role="tab" data-bind="text: ko.i18n('cohortDefinitions.cohortDefinitionManager.panels.json', 'JSON')"></a>
133137
</li>
134138

139+
<!-- Hide this not-so-useful part and make the page more 508 compliant:
135140
<li role="presentation"
136141
data-bind="css: { active: $component.exportTabMode() == 'sql' }, click: function() { $component.exportTabMode('sql');}">
137142
<a role="tab" data-bind="text: ko.i18n('cohortDefinitions.cohortDefinitionManager.panels.sql', 'SQL')"></a>
138143
</li>
144+
-->
139145
</ul>
140146

141147
<div class="tab-content">

js/pages/concept-sets/conceptset-browser.html

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@
88
title: ko.i18n('cs.browser.tabs.list', 'List'),
99
componentName: 'conceptsets-list',
1010
componentParams: componentParams,
11-
},
12-
{
13-
title: ko.i18n('cs.browser.tabs.export', 'Export'),
14-
componentName: 'conceptsets-export',
15-
componentParams: componentParams,
1611
}
1712
]"></tabs>
13+
<!-- Hide this not-so-useful part and make the page more 508 compliant:
14+
{
15+
title: ko.i18n('cs.browser.tabs.export', 'Export'),
16+
componentName: 'conceptsets-export',
17+
componentParams: componentParams,
18+
}
19+
-->
1820
</div>
1921

2022
<access-denied params="isAuthenticated: isAuthenticated, isPermitted: hasAccess"></access-denied>

js/pages/home/home.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<br/>
3030
<a data-bind="attr: { href: webapiReleaseUrl }" target="_new">WebAPI Version <span data-bind="text: webapiVersion"></span> Release Notes</a>
3131
</div>
32-
32+
<!-- Hide this not-so-useful part and make the page more 508 compliant:
3333
<div data-bind="hidden: loading">
3434
<div class="paddedWrapper" data-bind="html: ko.i18nformat('home.releaseNotes.issues', 'This latest release contains <b><%=issues%></b> feature enhancements and issue resolutions:', {issues: github_status().length})">
3535
<br/>
@@ -42,6 +42,7 @@
4242
</div>
4343
</div>
4444
</div>
45+
-->
4546
</div>
4647
<loading data-bind="visible: loading" params="status: ko.i18n('home.releaseNotes.loadingReleaseInfo', 'Loading release info')"></loading>
4748
</div>

0 commit comments

Comments
 (0)