Skip to content

Commit f259c04

Browse files
authored
Merge pull request #72 from uc-cdis/update_registry_in_constructors
Pass Registry to Counter and Gauge constructors
2 parents 5ff257e + 6f9eb69 commit f259c04

File tree

3 files changed

+47
-10
lines changed

3 files changed

+47
-10
lines changed

cdispyutils/metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def increment_counter(self, name, labels, description=""):
109109
logger.info(
110110
f"Creating counter '{name}' with description '{description}' and labels: {labels}"
111111
)
112-
self.prometheus_metrics[name] = Counter(name, description, [*labels.keys()])
112+
self.prometheus_metrics[name] = Counter(name, description, [*labels.keys()], registry=self._registry)
113113
elif type(self.prometheus_metrics[name]) is not Counter:
114114
raise ValueError(
115115
f"Trying to create counter '{name}' but a {type(self.prometheus_metrics[name])} with this name already exists"
@@ -177,7 +177,7 @@ def _create_gauge_if_not_exist(self, name, labels, value, description):
177177
logger.info(
178178
f"Creating gauge '{name}' with description '{description}' and labels: {labels}"
179179
)
180-
self.prometheus_metrics[name] = Gauge(name, description, [*labels.keys()])
180+
self.prometheus_metrics[name] = Gauge(name, description, [*labels.keys()], registry=self._registry)
181181
elif type(self.prometheus_metrics[name]) is not Gauge:
182182
raise ValueError(
183183
f"Trying to create gauge '{name}' but a {type(self.prometheus_metrics[name])} with this name already exists"

poetry.lock

Lines changed: 44 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "cdispyutils"
3-
version = "2.4.0"
3+
version = "2.4.1"
44
description = "This package includes several utility Python tools for the Gen3 stack."
55
authors = ["CTDS UChicago <cdis@uchicago.edu>"]
66
license = "Apache-2.0"

0 commit comments

Comments
 (0)