feat(discoveryDetailPanelTags): More general code cleanup

Author: jarvisraymond-uchicago

packages/frontend/src/features/Discovery/DiscoveryDropdownTagViewer.tsx

@@ -63,14 +63,10 @@ const MultiSelectContainer = ({ category }: MultiSelectContainerProps) => {
   const handleChange = (value: string[]) => {
     const previousValues = prevSelectionsRef.current;
     const removedTags = previousValues.filter((tag) => !value.includes(tag));
-    console.log('value', value);
-
     const addedTags = value.filter((tag) => !previousValues.includes(tag));
-
     setSelectedTags((prev) => {
       const updated = { ...prev };
       removedTags.forEach((tag) => delete updated[tag]);
-
       addedTags.forEach((tag) => {
         updated[tag] = true;
       });
@@ -117,16 +113,16 @@ const DiscoveryDropdownTagViewer = ({
   if (!tagCategoryData || tagCategoryData?.length === 0) return null;
 
   return (
-      <div
-        className={`grid sm:grid-cols-1
+    <div
+      className={`grid sm:grid-cols-1
           ${tagCategoryData.length > 1 && ' md:grid-cols-2 gap-4'}`}
-      >
-        {tagCategoryData.map((category, i) => (
-          <div key={i}>
-            <MultiSelectContainer category={category} />
-          </div>
-        ))}
-      </div>
+    >
+      {tagCategoryData.map((category, i) => (
+        <div key={i}>
+          <MultiSelectContainer category={category} />
+        </div>
+      ))}
+    </div>
   );
 };
 

packages/frontend/src/features/Discovery/DiscoveryIndexPanel.tsx

@@ -1,5 +1,4 @@
 import React, { ReactNode, useMemo, useRef, useState } from 'react';
-import { DiscoveryIndexConfig } from './types';
 import DiscoveryTable from './DiscoveryTable/DiscoveryTable';
 import { Button, Grid, Text } from '@mantine/core';
 import AdvancedSearchPanel from './Search/AdvancedSearchPanel';
@@ -65,9 +64,7 @@ const DiscoveryIndexPanel = ({ indexSelector }: DiscoveryIndexPanelProps) => {
   );
   const [selections, setSelections] = useState<string[]>([]); // table selections
   const [sorting, setSorting] = useState<MRT_SortingState>([]);
-  const [selectedTags, setSelectedTags] = useState<{ [key: string]: boolean }>(
-    {},
-  );
+
   const [advancedSearchTerms, setAdvancedSearchTerms] =
     useState<AdvancedSearchTerms>({
       operation: SearchCombination.and,

packages/frontend/src/features/Discovery/DiscoveryTable/TableRenderers/RowDetailPanelTags.tsx

@@ -9,7 +9,6 @@ interface RowDetailPanelProps {
 }
 
 const RowDetailPanelTags = ({ rowTags }: RowDetailPanelProps) => {
-  rowTags as TagData[];
   const {
     discoveryConfig: config,
     selectedTags,