ls unit test

Author: paulineribeyre

.secrets.baseline

@@ -205,9 +205,9 @@
         "filename": "tests/test_s3_endpoint.py",
         "hashed_secret": "08d2e98e6754af941484848930ccbaddfefe13d6",
         "is_verified": false,
-        "line_number": 75
+        "line_number": 77
       }
     ]
   },
-  "generated_at": "2026-02-25T19:02:33Z"
+  "generated_at": "2026-02-27T22:12:14Z"
 }

gen3workflow/routes/s3.py

@@ -166,10 +166,14 @@ async def s3_endpoint(path: str, request: Request):
     not support S3 endpoints with a path, such as the Minio-go S3 client.
     """
 
-    # because this endpoint is exposed at root, if the GET path is empty, assume the user is not
-    # trying to reach the S3 endpoint and redirect to the status endpoint instead
-    if request.method == "GET" and not path:
-        return await get_status(request)
+    # Because this endpoint is exposed at root, if the GET path is empty, the user may not be
+    # trying to reach the S3 endpoint: suggest using the status endpoint.
+    # "All buckets" listing requests also land here and are not supported, since users can only
+    # access their own bucket.
+    if request.method == "GET" and path in ("", "s3"):
+        err_msg = f"If you are using the S3 endpoint: 's3 ls' not supported, use 's3 ls s3://<your bucket>' instead. If you are trying to reach the Gen3-Workflow API, try '/_status'."
+        logger.error(err_msg)
+        raise HTTPException(HTTP_400_BAD_REQUEST, err_msg)
 
     # extract the caller's access token from the request headers, and ensure the caller (user, or
     # client acting on behalf of the user) has access to run workflows

tests/test_s3_endpoint.py

@@ -1,10 +1,12 @@
+import re
+import tempfile
+from unittest.mock import AsyncMock, patch
+
 import boto3
 from botocore.config import Config
 from botocore.exceptions import ClientError
 from fastapi import HTTPException
-from unittest.mock import AsyncMock, patch
 import pytest
-import tempfile
 
 from conftest import MOCKED_S3_RESPONSE_DICT, TEST_USER_ID, TEST_USER_TOKEN
 from gen3workflow.config import config
@@ -207,6 +209,21 @@ def test_s3_endpoint_wrong_bucket(s3_client, access_token_patcher, bucket_name):
         s3_client.list_objects(Bucket=bucket_name)
 
 
+@pytest.mark.parametrize("client", [{"get_url": True}], indirect=True)
+def test_s3_endpoint_list_buckets(s3_client):
+    """
+    Listing all the buckets the user can access is not supported, since users can only access
+    their own bucket.
+    """
+    with pytest.raises(
+        ClientError,
+        match=re.escape(
+            "An error occurred (400) when calling the ListBuckets operation: Bad Request"
+        ),
+    ):
+        s3_client.list_buckets()
+
+
 @pytest.mark.asyncio
 @pytest.mark.parametrize("path", ["s3", ""], ids=["s3 path", "root path"])
 async def test_s3_endpoint_with_bearer_token(client, path):
@@ -331,7 +348,7 @@ async def test_set_access_token_and_get_user_id_invalid_auth():
 def test_s3_upload_file(s3_client, access_token_patcher, multipart):
     """
     Test that the boto3 `upload_file` function works with the `/s3` endpoint, both for a small
-    file uploaded in 1 chunk and for a large file uploaded in multiple chunks.
+    file uploaded in 1 part and for a large file uploaded in multiple parts.
     """
     with patch(
         "gen3workflow.aws_utils.get_existing_kms_key_for_bucket",

tests/test_system.py

@@ -2,7 +2,7 @@
 
 
 @pytest.mark.asyncio
-@pytest.mark.parametrize("endpoint", ["/", "/_status", "/_status/"])
+@pytest.mark.parametrize("endpoint", ["/_status", "/_status/"])
 @pytest.mark.parametrize(
     "client",
     [