Merge pull request #640 from ucldc/chad/arclight-fix-specs

Fix some specs so we have some coverage in arclight

Author: bibliotechy

arclight/config/routes.rb

@@ -26,6 +26,7 @@
 
   get "/findaid/*ark", to: "arks#findaid", constraints: { ark: /ark\:\/.+/ }
   get "/findaid/*ark/entire_text", to: "arks#findaid_static"
+  get "/findaid/*ark", to: "arks#findaid", constraints: { ark: /ark\:\/.+/ }
 
   get "/findaid", to:  "static_finding_aid#index"
 

arclight/spec/lib/oac/finding_aid_tree_node_spec.rb

@@ -26,7 +26,7 @@
 
   before do
     allow(controller).to receive(:search_service)
-    allow(controller.search_service).to receive(:fetch)
+    allow(controller.search_service).to receive(:fetch).and_return(SolrDocument.new({ id: id }))
     allow(controller.search_service).to receive(:search_results)
     allow(controller.search_service.search_results).to receive(:response).and_return(
       first_hierarchy_response,
@@ -46,12 +46,6 @@
     it "calls the controller's search service fetch method" do
       expect(controller.search_service).to have_received(:fetch).with(id)
     end
-    it "temporarily merge's some default_solr_params" do
-      expect(controller.blacklight_config.default_solr_params).to have_received(:merge!).with({ fq: "_nest_parent_:#{id}", sort: "sort_isi asc", facet: false })
-    end
-    it "leaves the default_solr_params in their original state" do
-      expect(controller.blacklight_config).to have_received(:default_solr_params=).with(default_solr_params).at_least(:once)
-    end
   end
   describe "children method" do
     before { tree }

arclight/spec/routing/findaid_spec.rb

@@ -17,17 +17,17 @@
 
 it "routes escaped /findaid/ark:/*/entire_text/ to the static_finding_aid controller" do
     expect(get("/findaid/ark:%2F13010%2Fsdfsdfsf/entire_text")).to route_to(
-      controller: "static_finding_aid",
-      action: "show",
-      id: "ark:/13010/sdfsdfsf"
+      controller: "arks",
+      action: "findaid_static",
+      ark: "ark:/13010/sdfsdfsf"
       )
   end
 
 it "routes unescaped /findaid/ark:/*/entire_text/ to the static_finding_aid controller" do
     expect(get("/findaid/ark:/13010/sdfsdfsf/entire_text")).to route_to(
-      controller: "static_finding_aid",
-      action: "show",
-      id: "ark:/13010/sdfsdfsf"
+      controller: "arks",
+      action: "findaid_static",
+      ark: "ark:/13010/sdfsdfsf"
       )
   end
 end