Non-default Client for read requests(Get List) from the API server instead of the cache

Author: polefishu

pkg/controller/distributedrediscluster/sync_handler.go

@@ -350,7 +350,7 @@ func (r *ReconcileDistributedRedisCluster) sync(ctx *syncContext) error {
 		if err := clustering.RebalancedCluster(admin, newMasters); err != nil {
 			return Cluster.Wrap(err, "RebalancedCluster")
 		}
-	} else if len(newMasters) == len(curMasters) {
+	} else if cluster.Status.MinReplicationFactor < cluster.Spec.ClusterReplicas {
 		newRedisSlavesByMaster, bestEffort := clustering.PlaceSlaves(rCluster, newMasters, currentSlaveNodes, newSlave, cReplicaFactor)
 		if bestEffort {
 			rCluster.NodesPlacement = redisv1alpha1.NodesPlacementInfoBestEffort

pkg/controller/redisclusterbackup/helper.go

@@ -5,6 +5,7 @@ import (
 
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/rest"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
 	redisv1alpha1 "github.com/ucloud/redis-cluster-operator/pkg/apis/redis/v1alpha1"
@@ -91,3 +92,11 @@ func redisPassword(cluster *redisv1alpha1.DistributedRedisCluster) corev1.EnvVar
 		},
 	}
 }
+
+func newDirectClient(config *rest.Config) client.Client {
+	c, err := client.New(config, client.Options{})
+	if err != nil {
+		panic(err)
+	}
+	return c
+}

pkg/controller/redisclusterbackup/redisclusterbackup_controller.go

@@ -42,7 +42,8 @@ func Add(mgr manager.Manager) error {
 func newReconciler(mgr manager.Manager) reconcile.Reconciler {
 	r := &ReconcileRedisClusterBackup{client: mgr.GetClient(), scheme: mgr.GetScheme()}
 	r.crController = k8sutil.NewCRControl(r.client)
-	r.jobController = k8sutil.NewJobController(r.client)
+	r.directClient = newDirectClient(mgr.GetConfig())
+	r.jobController = k8sutil.NewJobController(r.directClient)
 	r.recorder = mgr.GetEventRecorderFor("redis-cluster-operator-backup")
 	return r
 }
@@ -109,9 +110,10 @@ var _ reconcile.Reconciler = &ReconcileRedisClusterBackup{}
 type ReconcileRedisClusterBackup struct {
 	// This client, initialized using mgr.Client() above, is a split client
 	// that reads objects from the cache and writes to the apiserver
-	client   client.Client
-	scheme   *runtime.Scheme
-	recorder record.EventRecorder
+	client       client.Client
+	directClient client.Client
+	scheme       *runtime.Scheme
+	recorder     record.EventRecorder
 
 	crController  k8sutil.ICustomResource
 	jobController k8sutil.IJobControl

pkg/controller/redisclusterbackup/sync_handler.go

@@ -180,7 +180,7 @@ func (r *ReconcileRedisClusterBackup) create(reqLogger logr.Logger, backup *redi
 		return err
 	}
 
-	reqLogger.V(4).Info("Backup running")
+	reqLogger.Info("Backup running")
 	r.recorder.Event(
 		backup,
 		corev1.EventTypeNormal,
@@ -502,6 +502,7 @@ func (r *ReconcileRedisClusterBackup) handleBackupJob(reqLogger logr.Logger, bac
 
 				if jobSucceeded {
 					msg := "Successfully completed backup"
+					reqLogger.Info(msg)
 					r.recorder.Event(
 						backup,
 						corev1.EventTypeNormal,
@@ -516,6 +517,7 @@ func (r *ReconcileRedisClusterBackup) handleBackupJob(reqLogger logr.Logger, bac
 					)
 				} else {
 					msg := "Failed to complete backup"
+					reqLogger.Info(msg)
 					r.recorder.Event(
 						backup,
 						corev1.EventTypeWarning,