Skip to content

Commit a905028

Browse files
committed
NumValue is not useful and was annotated oddly in the Czech data.
1 parent 027eaf4 commit a905028

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

udapi/block/ud/cs/markfeatsbugs.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -408,29 +408,26 @@ def process_node(self, node):
408408
'NumForm': ['Digit', 'Roman']
409409
})
410410
else:
411-
###!!! Somehow the NumValue feature from PDT via Interset is useless.
412411
# 'jeden' has Gender, Animacy, Number, Case: jeden, jedna, jedno, jednoho, jednomu, jednom, jedním, jedné, jednu, jednou, jedni, jedny, jedněch, jedněm, jedněmi.
413412
# 'dva', 'oba' have Gender, Number=Dual(Plur in modern Czech), Case: dva, dvě, dvou, dvěma.
414413
# 'tři', 'čtyři' have Number=Plur, Case: tři, třech, třem, třemi.
415414
# 'pět' and more have Number=Plur, Case: pět, pěti.
416415
if node.lemma == 'jeden':
417-
self.check_required_features(node, ['NumType', 'NumForm', 'NumValue', 'Number', 'Case'])
416+
self.check_required_features(node, ['NumType', 'NumForm', 'Number', 'Case'])
418417
self.check_allowed_features(node, {
419418
'NumType': ['Card'],
420419
'NumForm': ['Word'],
421-
'NumValue': ['1,2,3'],
422420
'Gender': ['Masc', 'Masc,Neut', 'Fem', 'Fem,Neut', 'Neut'], # similarly to determiners, genders are merged in some slots of the paradigm
423421
'Animacy': ['Anim', 'Inan'],
424422
'Number': ['Sing', 'Dual', 'Plur'],
425423
'Case': ['Nom', 'Gen', 'Dat', 'Acc', 'Voc', 'Loc', 'Ins']
426424
})
427425
elif re.match(r'^(dva|oba)$', node.lemma):
428-
self.check_required_features(node, ['NumType', 'NumForm', 'NumValue', 'Gender', 'Number', 'Case'])
426+
self.check_required_features(node, ['NumType', 'NumForm', 'Gender', 'Number', 'Case'])
429427
if self.pdt20:
430428
self.check_allowed_features(node, {
431429
'NumType': ['Card'],
432430
'NumForm': ['Word'],
433-
'NumValue': ['1,2,3'],
434431
'Gender': ['Masc', 'Masc,Neut', 'Fem', 'Fem,Neut', 'Neut'], # similarly to determiners, genders are merged in some slots of the paradigm
435432
'Number': ['Dual', 'Plur'],
436433
'Case': ['Nom', 'Gen', 'Dat', 'Acc', 'Voc', 'Loc', 'Ins']
@@ -439,7 +436,6 @@ def process_node(self, node):
439436
self.check_allowed_features(node, {
440437
'NumType': ['Card'],
441438
'NumForm': ['Word'],
442-
'NumValue': ['1,2,3'],
443439
'Gender': ['Masc', 'Fem', 'Neut'],
444440
'Animacy': ['Anim', 'Inan'],
445441
'Number': ['Dual', 'Plur'],
@@ -450,7 +446,6 @@ def process_node(self, node):
450446
self.check_allowed_features(node, {
451447
'NumType': ['Card'],
452448
'NumForm': ['Word'],
453-
'NumValue': ['1,2,3'],
454449
'Number': ['Plur'],
455450
'Case': ['Nom', 'Gen', 'Dat', 'Acc', 'Voc', 'Loc', 'Ins']
456451
})

0 commit comments

Comments
 (0)