Skip to content

Commit d6fa66f

Browse files
authored
[Dates] Make test more robust against non-UTC timezones (JuliaLang#55829)
`%M` is the format specifier for the minutes, not the month (which should be `%m`), and it was used twice. Also, on macOS `Libc.strptime` internally calls `mktime` which depends on the local timezone. We now temporarily set `TZ=UTC` to avoid depending on the local timezone. Fix JuliaLang#55827.
1 parent d9555c6 commit d6fa66f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

stdlib/Dates/test/types.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,11 @@ end
263263
end
264264

265265
@testset "issue #31524" begin
266-
dt1 = Libc.strptime("%Y-%M-%dT%H:%M:%SZ", "2018-11-16T10:26:14Z")
266+
# Ensure the result doesn't depend on local timezone, especially on macOS
267+
# where an extra internal call to `mktime` is affected by timezone settings.
268+
dt1 = withenv("TZ" => "UTC") do
269+
Libc.strptime("%Y-%m-%dT%H:%M:%SZ", "2018-11-16T10:26:14Z")
270+
end
267271
dt2 = Libc.TmStruct(14, 30, 5, 10, 1, 99, 3, 40, 0)
268272

269273
time = Time(dt1)

0 commit comments

Comments
 (0)