Issue #277

Author: Md. Alimuzzaman Alim

lib/classes/class-bootstrap.php

@@ -831,6 +831,18 @@ public function admin_enqueue_scripts( $hook ) {
             wp_enqueue_script( 'wp-stateless-angular' );
             wp_enqueue_script( 'wp-stateless' );
             wp_enqueue_style( 'jquery-ui-regenthumbs' );
+
+            $data = array(
+                    'key' => 'stateless-cache-busting',
+                    'class' => 'notice',
+                    'title' => sprintf( __( "Stateless mode enables and requires the Cache-Busting option.", ud_get_stateless_media()->domain ) ),
+                    'message' => sprintf( __("WordPress looks at local files to prevent files with the same filenames. 
+                                          Since Stateless mode bypasses this check, there is a potential for files to be stored with the same file name. We enforce the Cache-Busting option to prevent this. 
+                                          Override with the <a href='%s' target='_blank'>%s</a> constant.", ud_get_stateless_media()->domain),"https://github.com/wpCloud/wp-stateless/wiki/Constants#wp_stateless_media_cache_busting", "WP_STATELESS_MEDIA_CACHE_BUSTING" ),
+                  );
+            echo "<script id='template-stateless-cache-busting' type='text/html'>";
+            include ud_get_stateless_media()->path( '/static/views/error-notice.php', 'dir' );
+            echo "</script>";
           default: break;
         }
 
@@ -1075,15 +1087,19 @@ public function activate() {
       public function is_new_install($plugin =''){
         if( $plugin == plugin_basename( $this->boot_file ) ) {
           $sm_mode = get_option('sm_mode', null);
-          if(empty($sm_mode)){
+          $hashify_file_name = get_option('sm_hashify_file_name', null);
+          if($sm_mode == 'stateless' &&  $hashify_file_name == 'false'){
+            delete_option('dismissed_notice_stateless_cache_busting');
+          }
+          else{
             update_option('dismissed_notice_stateless_cache_busting', true);
           }
         }
       }
 
       public function show_notice_stateless_cache_busting(){
         $this->errors->add( array(
-          'key' => 'stateless_cache_busting',
+          'key' => 'stateless-cache-busting',
           'button' => 'View Settings',
           'button_link' => admin_url('upload.php?page=stateless-settings'),
           'title' => sprintf( __( "Stateless mode now requires the Cache-Busting option.", ud_get_stateless_media()->domain ) ),

lib/classes/class-errors.php

@@ -155,6 +155,16 @@ public function has_errors() {
       public function admin_notices() {
         global $wp_version;
 
+        wp_enqueue_style("stateless-error-style", ud_get_stateless_media()->path('static/styles/error-notice.css'));
+        //enqueue dismiss js for ajax requests
+        $script_path = \UsabilityDynamics\WP\Utility::path( 'static/scripts/ud-dismiss.js', 'url' );
+        wp_enqueue_script( "sateless-error-notice-js", ud_get_stateless_media()->path( 'static/scripts/error-notice.js', 'url' ), array( 'jquery' ) );
+        wp_enqueue_script( "ud-dismiss", $script_path, array( 'jquery' ) );
+        wp_localize_script( "ud-dismiss", "_ud_vars", array(
+            "ajaxurl" => admin_url( 'admin-ajax.php' ),
+        ) );
+
+
         //** Don't show the message if the user has no enough permissions. */
         if ( ! function_exists( 'wp_get_current_user' ) ) {
           require_once( ABSPATH . 'wp-includes/pluggable.php' );
@@ -179,10 +189,6 @@ public function admin_notices() {
 
         $errors = apply_filters( 'ud:errors:admin_notices', $this->errors, $this->args );
         $notices = apply_filters( 'stateless:notices:admin_notices', $this->notices, $this->args );
-        
-        if( !empty( $errors ) || !empty( $notices ) ) {
-          wp_enqueue_style("stateless-error-style", ud_get_stateless_media()->path('static/styles/error-notice.css'));
-        }
 
         //** Errors Block */
         if( !empty( $errors ) && is_array( $errors ) ) {
@@ -222,16 +228,6 @@ public function admin_notices() {
           }
         }
 
-        if ( $has_notice) {
-          //enqueue dismiss js for ajax requests
-          $script_path = \UsabilityDynamics\WP\Utility::path( 'static/scripts/ud-dismiss.js', 'url' );
-          wp_enqueue_script( "sateless-error-notice-js", ud_get_stateless_media()->path( 'static/scripts/error-notice.js', 'url' ), array( 'jquery' ) );
-          wp_enqueue_script( "ud-dismiss", $script_path, array( 'jquery' ) );
-          wp_localize_script( "ud-dismiss", "_ud_vars", array(
-              "ajaxurl" => admin_url( 'admin-ajax.php' ),
-          ) );
-        }
-        
       }
 
       /**

static/scripts/error-notice.js

@@ -26,5 +26,20 @@ jQuery( document ).ready( function () {
       }, "json" );
       return false;
     });
+
+    jQuery('#stless_settings_tab .sm-mode input[type=radio]').on('change', function(){
+      var $this = jQuery('#sm_mode_stateless');
+      if($this.is(':checked')){
+        var notice = jQuery('#stateless-notice-stateless-cache-busting');
+        if(!notice.length){
+          notice = jQuery(jQuery('#template-stateless-cache-busting').html());
+          notice.appendTo("#stateless-settings-page-title");
+        }
+        jQuery('#stateless-notice-stateless-cache-busting').show();
+      }
+      else{
+        jQuery('#stateless-notice-stateless-cache-busting').hide();
+      }
+    });
 
   } );

static/views/error-notice.php

@@ -1,4 +1,4 @@
-<div class="ud-admin-notice <?php echo $data['class'];?> update-nag fade">
+<div id="stateless-notice-<?php echo $data['key'];?>" class="ud-admin-notice <?php echo $data['class'];?> update-nag fade">
     <div>
         <div class="title"><?php echo $data['title'];?></div>
         <div class="description"><?php echo $data['message'];?></div>