Fix for issue #219

convert trigger error to enhanced stateless notice.

Author: Md. Alimuzzaman Alim

lib/classes/class-errors.php

@@ -206,14 +206,14 @@ public function admin_notices() {
               continue;
             }
 
-            $data = array(
-              'title' => $notice['title'],
+            $data = wp_parse_args($notice, array(
+              'title' => '',
               'class' => 'notice',
-              'message' => $notice['message'],
-              'button' => $notice['button'],
-              'key' => $notice['key'],
+              'message' => '',
+              'button' => '',
+              'key' => '',
               'action_links' => $this->action_links[ 'notices' ],
-            );
+            ));
 
             include ud_get_stateless_media()->path( '/static/views/error-notice.php', 'dir' );
 

lib/classes/class-settings.php

@@ -127,7 +127,11 @@ public function refresh() {
               }
               if(is_string($old_const) && defined($old_const)){
                   $value = constant($old_const);
-                  trigger_error(__(sprintf("`%s` constant is deprecated, please use `%s` instead.", $old_const, $new_const)), E_USER_WARNING);
+                  ud_get_stateless_media()->errors->add( array(
+                      'key' => $new_const,
+                      'title' => sprintf( __( "%s: Deprecated Notice (%s)", ud_get_stateless_media()->domain ), ud_get_stateless_media()->name, $new_const ),
+                      'message' => sprintf(__("`%s` constant is deprecated, please use `%s` instead.", ud_get_stateless_media()->domain), $old_const, $new_const),
+                  ), 'notice' );
                   $this->set( "sm.readonly.{$option}", "constant" );
                   break;
               }

lib/classes/compatibility/ICompatibility.php

@@ -105,7 +105,11 @@ public function init(){
                     if(is_string($old_const) && defined($old_const)){
                         $is_constant = true;
                         $this->enabled = constant($old_const);
-                        trigger_error(__(sprintf("`%s` constant is deprecated, please use `%s` instead.", $old_const, $new_const)), E_USER_WARNING);
+                        ud_get_stateless_media()->errors->add( array(
+                            'key' => $this->id,
+                            'title' => sprintf( __( "%s: Deprecated Notice (%s)", ud_get_stateless_media()->domain ), ud_get_stateless_media()->name, $this->title ),
+                            'message' => sprintf(__("<i>%s</i> constant is deprecated, please use <i>%s</i> instead.", ud_get_stateless_media()->domain), $old_const, $new_const),
+                        ), 'notice' );
                         break;
                     }
                 }