Skip to content

Commit 52abc09

Browse files
empty2filljwindgassen
authored andcommitted
Fix UE version check
- FTabManager::InvokeTab is deprecated - TMicRecursionGuard
1 parent 32cae76 commit 52abc09

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

Source/Linter/Private/LintRule.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "Modules/ModuleManager.h"
99
#include "IAssetTools.h"
1010
#include "AssetRegistryModule.h"
11+
#include "Misc/EngineVersionComparison.h"
1112

1213

1314
ULintRule::ULintRule(const FObjectInitializer& ObjectInitializer)
@@ -59,7 +60,7 @@ FName ULintRule::GetRuleBasedObjectVariantName_Implementation(UObject* ObjectToL
5960
const UMaterialInterface* MI = Cast<UMaterialInterface>(ObjectToLint);
6061
if (MI != nullptr)
6162
{
62-
#if ENGINE_MINOR_VERSION >= 25 || ENGINE_MAJOR_VERSION >= 5
63+
#if UE_VERSION_NEWER_THAN(4, 25, 0)
6364
TMicRecursionGuard RecursionGuard;
6465
#else
6566
UMaterialInterface::TMicRecursionGuard RecursionGuard;

Source/Linter/Private/LinterContentBrowserExtensions.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
#include "Framework/Commands/UIAction.h"
1313
#include "Delegates/IDelegateInstance.h"
1414
#include "TooltipEditor/TooltipTool.h"
15+
#include "Linter.h"
16+
#include "BatchRenameTool/BatchRenameTool.h"
17+
#include "Misc/EngineVersionComparison.h"
1518

1619
#define LOCTEXT_NAMESPACE "Linter"
1720

@@ -51,7 +54,11 @@ void FLinterContentBrowserExtensions::InstallHooks(FLinterModule* LinterModule,
5154
{
5255
Linter->SetDesiredLintPaths(SelectedPaths);
5356
}
57+
#if UE_VERSION_NEWER_THAN(4, 26, 0)
5458
FGlobalTabmanager::Get()->TryInvokeTab(FName("LinterTab"));
59+
#else
60+
FGlobalTabmanager::Get()->InvokeTab(FName("LinterTab"));
61+
#endif
5562
}
5663
})),
5764
NAME_None,

Source/Linter/Private/UI/LintWizard.cpp

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@
1919
#include "FileHelpers.h"
2020
#include "Logging/MessageLog.h"
2121
#include "Logging/TokenizedMessage.h"
22+
#include "ContentBrowserModule.h"
23+
#include "DesktopPlatformModule.h"
24+
#include "AssetToolsModule.h"
25+
#include "Framework/Docking/TabManager.h"
26+
#include "Widgets/Input/SComboBox.h"
27+
#include "Widgets/Docking/SDockTab.h"
28+
#include "Misc/App.h"
29+
#include "Engine/World.h"
30+
#include "Misc/EngineVersionComparison.h"
2231

2332
#include "LinterStyle.h"
2433
#include "LintRuleSet.h"
@@ -88,7 +97,11 @@ void SLintWizard::Construct(const FArguments& InArgs)
8897
.FinishButtonText(LOCTEXT("FinishButtonText", "Close"))
8998
.OnFinished_Lambda([&]()
9099
{
100+
#if UE_VERSION_NEWER_THAN(4, 26, 0)
91101
FGlobalTabmanager::Get()->TryInvokeTab(FName("LinterTab"))->RequestCloseTab();
102+
#else
103+
FGlobalTabmanager::Get()->InvokeTab(FName("LinterTab"))->RequestCloseTab();
104+
#endif
92105
})
93106
+ SWizard::Page()
94107
.CanShow_Lambda([&]() { return RuleSets.Num() > 0; })
@@ -521,7 +534,15 @@ void SLintWizard::Construct(const FArguments& InArgs)
521534
LOCTEXT("ZipTaskShortName", "Zip Project Task"), FAppStyle::GetBrush(TEXT("MainFrame.CookContent")));
522535
}
523536

537+
<<<<<<< HEAD:Source/Linter/Private/UI/LintWizard.cpp
538+
FGlobalTabmanager::Get()->TryInvokeTab(FName("LinterTab"))->RequestCloseTab();
539+
=======
540+
#if UE_VERSION_NEWER_THAN(4, 26, 0)
524541
FGlobalTabmanager::Get()->TryInvokeTab(FName("LinterTab"))->RequestCloseTab();
542+
#else
543+
FGlobalTabmanager::Get()->InvokeTab(FName("LinterTab"))->RequestCloseTab();
544+
#endif
545+
>>>>>>> 7384b2d (Fix UE version check):Plugins/Linter/Source/Linter/Private/UI/LintWizard.cpp
525546
}
526547
return FReply::Handled();
527548
})

0 commit comments

Comments
 (0)