Skip to content

Commit e895390

Browse files
committed
Addressed CR comments.
1 parent 8571cfb commit e895390

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

framework.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
version of Python, we have to distribute full versions for the engine to function.
1010
"""
1111

12-
import sgtk
13-
import sys
1412
import os
1513
import platform
16-
import site
1714
import re
15+
import site
16+
import sys
17+
18+
import sgtk
1819

1920

2021
class UnrealQtFramework(sgtk.platform.Framework):
@@ -23,11 +24,14 @@ class UnrealQtFramework(sgtk.platform.Framework):
2324
# init and destroy
2425

2526
def init_framework(self):
27+
"""
28+
This framework ships with additional Python packages and tweak the Python
29+
paths environment to make these packages available to apps and engines.
30+
31+
Something similar to what `virtualenv` does is done when this framework is
32+
loaded by SG TK.
33+
"""
2634
self.log_debug("%s: Initializing UnrealQtFramework..." % self)
27-
28-
# This framework ships with additional Python packages
29-
# make these packages available to apps and engines using
30-
# this framework
3135

3236
# Remap the platform name to our names
3337
pname = self.platform_name()

hooks/tk-multi-publish2/tk-maya/unreal/unreal_setup_turntable.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ def setup_render_with_movie_render_queue(output_path, unreal_map_path, sequence_
1818
with the Movie Render queue is not possible.
1919
"""
2020
# Check if we can use the Movie render queue, bail out if we can't
21-
if "MoviePipelineQueueEngineSubsystem" not in dir(unreal):
21+
if not hasattr(unreal, "MoviePipelineQueueEngineSubsystem"):
2222
unreal.log(
2323
"Movie Render Queue is not available, Movie queue rendering can't be setup."
2424
)
2525
return None
26-
if "MoviePipelineAppleProResOutput" not in dir(unreal):
26+
if not hasattr(unreal, "MoviePipelineAppleProResOutput"):
2727
unreal.log(
2828
"Apple ProRes Media plugin must be loaded to be able to render with the Movie Render Queue, "
2929
"Movie queue rendering can't be setup."
@@ -151,7 +151,7 @@ def setup_turntable(fbx_file_path, assets_path, turntable_map_path):
151151
assets_path = os.environ["UNREAL_SG_ASSETS_PATH"]
152152
turntable_map_path = os.environ["UNREAL_SG_MAP_PATH"]
153153

154-
# Additional settings to render with the Movie Render Queue
154+
# Additional optional settings to render with the Movie Render Queue
155155
movie_path = os.environ.get("UNREAL_SG_MOVIE_OUTPUT_PATH")
156156
level_sequence_path = os.environ.get("UNREAL_SG_SEQUENCE_PATH")
157157

0 commit comments

Comments
 (0)