Addressed CR comments

Author: gplsteph

.gitignore

@@ -34,3 +34,4 @@ pip-log.txt
 
 # Visual Studio
 .vs
+.vscode

.pre-commit-config.yaml

@@ -0,0 +1,35 @@
+# This file is based on templates provided and copyrighted by Autodesk, Inc.
+# This file has been modified by Epic Games, Inc. and is subject to the license
+# file included in this repository.
+
+# Styles the code properly
+# Exclude the UI files, as they are auto-generated.
+exclude: "ui\/.*py$"
+# List of super useful formatters.
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.4.0
+    hooks:
+    # Ensures the code is syntaxically correct
+    - id: check-ast
+      language_version: python3
+    # Ensures a file name will resolve on all platform
+    - id: check-case-conflict
+    # Checks files with the execute bit set have shebangs
+    - id: check-executables-have-shebangs
+    # Ensure there's no incomplete merges
+    - id: check-merge-conflict
+    # Adds an empty line if missing at the end of a file.
+    - id: end-of-file-fixer
+    # Makes sure requirements.txt is properly formatted
+    - id: requirements-txt-fixer
+    # Removes trailing whitespaces.
+    - id: trailing-whitespace
+  # Leave black at the bottom so all touchups are done before it is run.
+  - repo: https://github.com/ambv/black
+    rev: 19.10b0
+    hooks:
+    - id: black
+      language_version: python3
+
+

hooks/tk-multi-publish2/basic/collector.py

@@ -86,13 +86,6 @@ def collect_current_session(self, settings, parent_item):
         """
         # Create the session item for the publish hierarchy
         # In Unreal, the current session can be defined as the current level/map (.umap)
-        # display_name = "Current Unreal Session"   # Could retrieve the level name
-#         session_item = parent_item.create_item(
-#             "unreal.session",
-#             "Unreal Session",
-#             display_name
-#         )
-
         # Don't create a session item for now since the .umap does not need to be published
         session_item = parent_item
 

hooks/tk-multi-publish2/basic/publish_movie.py

@@ -324,8 +324,8 @@ def validate(self, settings, item):
         # Check if we can use the Movie Render queue available from 4.26
         use_movie_render_queue = False
         render_presets = None
-        if "MoviePipelineQueueEngineSubsystem" in dir(unreal):
-            if "MoviePipelineAppleProResOutput" in dir(unreal):
+        if hasattr(unreal, "MoviePipelineQueueEngineSubsystem"):
+            if hasattr(unreal, "MoviePipelineAppleProResOutput"):
                 use_movie_render_queue = True
                 self.logger.info("Movie Render Queue will be used for rendering.")
                 render_presets_path = settings["Movie Render Queue Presets Path"].value
@@ -357,7 +357,7 @@ def validate(self, settings, item):
             error_msg = "Missing keys required for the publish template " \
                         "%s" % (missing_keys)
             self.logger.error(error_msg)
-            raise Exception(error_msg)
+            raise ValueError(error_msg)
 
         item.properties["path"] = publish_template.apply_fields(fields)
         item.properties["publish_path"] = item.properties["path"]
@@ -570,7 +570,7 @@ def _unreal_render_sequence_with_sequencer(self, output_path, unreal_map_path, s
         movie_name = os.path.splitext(output_file)[0]
 
         # First, check if there's a file that will interfere with the output of the Sequencer
-        # Sequencer can only render to avi file format
+        # Sequencer can only render to avi or mov file format
         if os.path.isfile(output_path):
             # Must delete it first, otherwise the Sequencer will add a number in the filename
             try: